Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: src/compiler/linkage.cc

Issue 1460183002: [turbofan] Add general support for sp-based frame access (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Last comment addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/linkage.h ('k') | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/linkage.cc
diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc
index cc67fe5007988b3b1368aa0c798996100c116cc3..5c49d5c7c48658827789c43e011fc172ebb879fe 100644
--- a/src/compiler/linkage.cc
+++ b/src/compiler/linkage.cc
@@ -147,24 +147,6 @@ CallDescriptor* Linkage::ComputeIncoming(Zone* zone, CompilationInfo* info) {
}
-FrameOffset Linkage::GetFrameOffset(int spill_slot, Frame* frame) const {
- bool has_frame = frame->GetSpillSlotCount() > 0 ||
- incoming_->IsJSFunctionCall() ||
- incoming_->kind() == CallDescriptor::kCallAddress;
- const int offset =
- (StandardFrameConstants::kFixedSlotCountAboveFp - spill_slot - 1) *
- kPointerSize;
- if (has_frame) {
- return FrameOffset::FromFramePointer(offset);
- } else {
- // No frame. Retrieve all parameters relative to stack pointer.
- DCHECK(spill_slot < 0); // Must be a parameter.
- int sp_offset = offset + (frame->GetSpToFpSlotCount() * kPointerSize);
- return FrameOffset::FromStackPointer(sp_offset);
- }
-}
-
-
// static
int Linkage::FrameStateInputCount(Runtime::FunctionId function) {
// Most runtime functions need a FrameState. A few chosen ones that we know
« no previous file with comments | « src/compiler/linkage.h ('k') | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698