Issue 146013002: Fix HGraphBuilder::AddSimulate to pass removable down correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146013002: Fix HGraphBuilder::AddSimulate to pass removable down correctly (Closed)

Created:
6 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
6 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix HGraphBuilder::AddSimulate to pass removable down correctly It was passed as a position argument previously making all simulates added with it conservatively FIXED_SIMULATE. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18822

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Chromium)

Hi Jakob! I was doing a bit of hacking on V8 and discovered this minor ...

6 years, 11 months ago (2014-01-23 20:12:36 UTC) #1

Jakob Kummerow

LGTM, thanks for fixing this! > (All praise the silent ENUM to int coercion!). It's ...

6 years, 11 months ago (2014-01-23 20:47:29 UTC) #2

Vyacheslav Egorov (Chromium)

6 years, 11 months ago (2014-01-24 12:22:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18822 (presubmit successful).