Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 146013002: Fix HGraphBuilder::AddSimulate to pass removable down correctly (Closed)

Created:
6 years, 11 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix HGraphBuilder::AddSimulate to pass removable down correctly It was passed as a position argument previously making all simulates added with it conservatively FIXED_SIMULATE. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
Hi Jakob! I was doing a bit of hacking on V8 and discovered this minor ...
6 years, 11 months ago (2014-01-23 20:12:36 UTC) #1
Jakob Kummerow
LGTM, thanks for fixing this! > (All praise the silent ENUM to int coercion!). It's ...
6 years, 11 months ago (2014-01-23 20:47:29 UTC) #2
Vyacheslav Egorov (Chromium)
6 years, 11 months ago (2014-01-24 12:22:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18822 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698