Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1460123002: Clean-up the registration of plugins (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson
Modified:
5 years, 1 month ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -85 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +13 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +5 lines, -32 lines 2 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 5 chunks +7 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 13 chunks +8 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 4 chunks +10 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/inputs_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 1 month ago (2015-11-20 01:11:14 UTC) #2
pquitslund
LGTM https://codereview.chromium.org/1460123002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1460123002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode5993 pkg/analyzer/lib/src/generated/engine.dart:5993: return <Plugin>[enginePlugin, commandLinePlugin, optionsPlugin]; Is there any reason ...
5 years, 1 month ago (2015-11-20 04:34:09 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1460123002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/1460123002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode5993 pkg/analyzer/lib/src/generated/engine.dart:5993: return <Plugin>[enginePlugin, commandLinePlugin, optionsPlugin]; > Is there any reason ...
5 years, 1 month ago (2015-11-20 14:23:18 UTC) #4
Brian Wilkerson
5 years, 1 month ago (2015-11-20 16:14:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1367d2d47d6b68567cba4412dc779e4f4c535acc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698