Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1460113002: GN: Make Windows installer 'archive' action depend on NaCl IRT (Closed)

Created:
5 years, 1 month ago by Roland McGrath
Modified:
5 years, 1 month ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Make Windows installer 'archive' action depend on NaCl IRT The action uses the NaCl IRT files as inputs, but lacks the necessary dependencies on the the targets that build them. BUG=512869 R=dpranke@chromium.org, gab@chromium.org Committed: https://crrev.com/fd9f7970b7e7f650fa7b07dbdf308ce28f744ffd Cr-Commit-Position: refs/heads/master@{#361190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Roland McGrath
5 years, 1 month ago (2015-11-20 00:40:33 UTC) #1
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-20 03:17:56 UTC) #2
Roland McGrath
gab: OWNERS review for chrome/installer/ please
5 years, 1 month ago (2015-11-20 17:56:02 UTC) #3
grt (UTC plus 2)
is the .gyp build also missing this dependency? if so, could you fix it there, ...
5 years, 1 month ago (2015-11-23 20:05:10 UTC) #5
Roland McGrath
On 2015/11/23 20:05:10, grt wrote: > is the .gyp build also missing this dependency? if ...
5 years, 1 month ago (2015-11-23 20:21:30 UTC) #6
grt (UTC plus 2)
On 2015/11/23 20:21:30, Roland McGrath wrote: > On 2015/11/23 20:05:10, grt wrote: > > is ...
5 years, 1 month ago (2015-11-23 20:40:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460113002/1
5 years, 1 month ago (2015-11-23 20:44:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 21:39:15 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 21:39:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd9f7970b7e7f650fa7b07dbdf308ce28f744ffd
Cr-Commit-Position: refs/heads/master@{#361190}

Powered by Google App Engine
This is Rietveld 408576698