Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: src/codec/SkCodec_libgif.cpp

Issue 1460073002: Implement SkGifCodec::onSkipScanlines() (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: onSkipScanlines() returns a bool Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/codec/SkCodec_libgif.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codec/SkCodec_libgif.cpp
diff --git a/src/codec/SkCodec_libgif.cpp b/src/codec/SkCodec_libgif.cpp
index 65503558aaab8635899f62a280ead32d96ad5605..8021af95a2e050f1b2df82985d9f467203e108b2 100644
--- a/src/codec/SkCodec_libgif.cpp
+++ b/src/codec/SkCodec_libgif.cpp
@@ -506,10 +506,36 @@ SkCodec::Result SkGifCodec::onStartScanlineDecode(const SkImageInfo& dstInfo,
return this->prepareToDecode(dstInfo, inputColorPtr, inputColorCount, this->options());
}
+void SkGifCodec::handleScanlineFrame(int count, int* rowsBeforeFrame, int* rowsInFrame) {
+ if (fFrameIsSubset) {
+ const int currRow = this->INHERITED::nextScanline();
+
+ // The number of rows that remain to be skipped before reaching rows that we
+ // actually must decode into.
+ // This must be at least zero. We also make sure that it is less than or
+ // equal to count, since we will skip at most count rows.
+ *rowsBeforeFrame = SkTMin(count, SkTMax(0, fFrameRect.top() - currRow));
+
+ // Rows left to decode once we reach the start of the frame.
+ const int rowsLeft = count - *rowsBeforeFrame;
+
+ // Count the number of that extend beyond the bottom of the frame. We do not
+ // need to decode into these rows.
+ const int rowsAfterFrame = SkTMax(0, currRow + rowsLeft - fFrameRect.bottom());
+
+ // Set the actual number of source rows that we need to decode.
+ *rowsInFrame = rowsLeft - rowsAfterFrame;
+ } else {
+ *rowsBeforeFrame = 0;
+ *rowsInFrame = count;
+ }
+}
+
int SkGifCodec::onGetScanlines(void* dst, int count, size_t rowBytes) {
- int rowsBeforeFrame = 0;
- int rowsAfterFrame = 0;
- int rowsInFrame = count;
+ int rowsBeforeFrame;
+ int rowsInFrame;
+ this->handleScanlineFrame(count, &rowsBeforeFrame, &rowsInFrame);
+
if (fFrameIsSubset) {
// Fill the requested rows
SkImageInfo fillInfo = this->dstInfo().makeWH(this->dstInfo().width(), count);
@@ -517,15 +543,8 @@ int SkGifCodec::onGetScanlines(void* dst, int count, size_t rowBytes) {
this->dstInfo().alphaType());
fSwizzler->fill(fillInfo, dst, rowBytes, fillValue, this->options().fZeroInitialized);
- // Do nothing for rows before the image frame
- rowsBeforeFrame = SkTMax(0, fFrameRect.top() - this->INHERITED::nextScanline());
- rowsInFrame = SkTMax(0, rowsInFrame - rowsBeforeFrame);
+ // Start to write pixels at the start of the image frame
dst = SkTAddOffset<void>(dst, rowBytes * rowsBeforeFrame);
-
- // Do nothing for rows after the image frame
- rowsAfterFrame = SkTMax(0,
- this->INHERITED::nextScanline() + rowsInFrame - fFrameRect.bottom());
- rowsInFrame = SkTMax(0, rowsInFrame - rowsAfterFrame);
}
for (int i = 0; i < rowsInFrame; i++) {
@@ -539,6 +558,20 @@ int SkGifCodec::onGetScanlines(void* dst, int count, size_t rowBytes) {
return count;
}
+bool SkGifCodec::onSkipScanlines(int count) {
+ int rowsBeforeFrame;
+ int rowsInFrame;
+ this->handleScanlineFrame(count, &rowsBeforeFrame, &rowsInFrame);
+
+ for (int i = 0; i < rowsInFrame; i++) {
+ if (!this->readRow()) {
+ return false;
+ }
+ }
+
+ return true;
+}
+
SkCodec::SkScanlineOrder SkGifCodec::onGetScanlineOrder() const {
if (fGif->Image.Interlace) {
return kOutOfOrder_SkScanlineOrder;
« no previous file with comments | « src/codec/SkCodec_libgif.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698