Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1460063006: [heap] report allocated object to the inline-allocation-observers (Closed)

Created:
5 years, 1 month ago by ofrobots
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] report allocated object to the inline-allocation-observers Makes it possible for the the inline allocation observers to be sample the actual object allocation on which the notification triggers. R=hpayer@chromium.org BUG= Committed: https://crrev.com/e7560013e30f3333744d0385142689c98a8ed986 Cr-Commit-Position: refs/heads/master@{#32209}

Patch Set 1 #

Patch Set 2 : fixup after rebase #

Total comments: 4

Patch Set 3 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 1 2 2 chunks +18 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 1 5 chunks +9 lines, -6 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ofrobots
5 years, 1 month ago (2015-11-20 18:34:43 UTC) #1
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1460063006/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1460063006/diff/20001/src/heap/spaces.h#newcode2530 src/heap/spaces.h:2530: // 1) soon_object will be nullptr in cases ...
5 years ago (2015-11-24 10:56:09 UTC) #2
ofrobots
https://codereview.chromium.org/1460063006/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1460063006/diff/20001/src/heap/spaces.h#newcode2530 src/heap/spaces.h:2530: // 1) soon_object will be nullptr in cases where ...
5 years ago (2015-11-24 13:04:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460063006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460063006/40001
5 years ago (2015-11-24 13:04:59 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-24 13:47:34 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 13:48:10 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7560013e30f3333744d0385142689c98a8ed986
Cr-Commit-Position: refs/heads/master@{#32209}

Powered by Google App Engine
This is Rietveld 408576698