SimpleCache: Fix race condition in simple_index_file_unittest

SimpleCache: Fix race condition in simple_index_file_unittest

The MessageLoopHelper 'helper' is created on the main thread in this test, so to
avoid a race condition move invocation of helper.CallbackCalled() from
CacheThread to the main thread.

BUG=313726
Committed: https://crrev.com/07477ffeefe3587f8d91b36d388e7fb73dc4d8da
Cr-Commit-Position: refs/heads/master@{#362429}

[pasko, 2015-11-20 19:45:42]

Description was changed from

==========
SimpleCache: Fix race condition in simple_index_file_unittest

The MessageLoopHelper 'helper' is created on the main thread in this test, so to
avoid a race condition move invocation of helper.CallbackCalled() from
CacheThread to the main thread.

BUG=313726
==========

to

==========
SimpleCache: Fix race condition in simple_index_file_unittest

The MessageLoopHelper 'helper' is created on the main thread in this test, so to
avoid a race condition move invocation of helper.CallbackCalled() from
CacheThread to the main thread.

BUG=313726
==========

[pasko, 2015-11-20 19:45:43]

pasko@chromium.org changed reviewers:
+ gavinp@chromium.org, glider@chromium.org

[pasko, 2015-11-20 19:52:16]

gavinp: given how easy it is to fix this bug, it's been around for too long;
PTaL.

glider: I did not run it under thread sanitizer, but I believe it should do it

[pasko, 2015-11-20 19:53:28]

The CQ bit was checked by pasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-20 19:54:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460053003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460053003/20001

[commit-bot: I haz the power, 2015-11-20 20:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 20:33:42]

Dry run: This issue passed the CQ dry run.

[Alexander Potapenko, 2015-11-23 11:44:21]

lgtm

LGTM

[pasko, 2015-11-24 21:47:16]

gavinp: please take a look

[pasko, 2015-11-25 18:21:22]

I checked that the failing linux_chromium_tsan_rel_ng bot is not failing because
of relaxed tsan_suppressions (the string "CallbackWasCalled" is nowhere in the
output).

gavinp: PTaL

[pasko, 2015-11-26 12:10:49]

gavinp: I hope you are well. Please take a look at this trivial fix. Yes, race
conditions can be trivial when you know the variable name ('helper') and thread
names (the main thread and the cache thread).

[pasko, 2015-11-30 13:07:45]

gavinp: ping

[gavinp, 2015-12-01 15:16:27]

lgtm. cute.

[Alexander Potapenko, 2015-12-01 15:18:19]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2015-12-01 15:18:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460053003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460053003/20001

[commit-bot: I haz the power, 2015-12-01 16:31:59]

Description was changed from

==========
SimpleCache: Fix race condition in simple_index_file_unittest

The MessageLoopHelper 'helper' is created on the main thread in this test, so to
avoid a race condition move invocation of helper.CallbackCalled() from
CacheThread to the main thread.

BUG=313726
==========

to

==========
SimpleCache: Fix race condition in simple_index_file_unittest

The MessageLoopHelper 'helper' is created on the main thread in this test, so to
avoid a race condition move invocation of helper.CallbackCalled() from
CacheThread to the main thread.

BUG=313726
==========

[commit-bot: I haz the power, 2015-12-01 16:32:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-01 16:32:44]

Description was changed from

==========
SimpleCache: Fix race condition in simple_index_file_unittest

The MessageLoopHelper 'helper' is created on the main thread in this test, so to
avoid a race condition move invocation of helper.CallbackCalled() from
CacheThread to the main thread.

BUG=313726
==========

to

==========
SimpleCache: Fix race condition in simple_index_file_unittest

The MessageLoopHelper 'helper' is created on the main thread in this test, so to
avoid a race condition move invocation of helper.CallbackCalled() from
CacheThread to the main thread.

BUG=313726

Committed: https://crrev.com/07477ffeefe3587f8d91b36d388e7fb73dc4d8da
Cr-Commit-Position: refs/heads/master@{#362429}
==========

[commit-bot: I haz the power, 2015-12-01 16:32:44]

Patchset 2 (id:??) landed as
https://crrev.com/07477ffeefe3587f8d91b36d388e7fb73dc4d8da
Cr-Commit-Position: refs/heads/master@{#362429}