Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 146005: Disk Cache: Implement GetAvailableRange for the regular disk cache.... (Closed)

Created:
11 years, 6 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Disk Cache: Implement GetAvailableRange for the regular disk cache. This is required to enable sparse caching. BUG=12258 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19069

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -17 lines) Patch
M net/disk_cache/entry_unittest.cc View 3 chunks +55 lines, -1 line 2 comments Download
M net/disk_cache/sparse_control.h View 3 chunks +6 lines, -1 line 0 comments Download
M net/disk_cache/sparse_control.cc View 7 chunks +65 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rvargas (doing something else)
11 years, 6 months ago (2009-06-23 00:47:11 UTC) #1
Nicolas Sylvain
http://codereview.chromium.org/146005/diff/1/4 File net/disk_cache/entry_unittest.cc (right): http://codereview.chromium.org/146005/diff/1/4#newcode1024 Line 1024: EXPECT_EQ(kSize, entry->GetAvailableRange(0, 0x2100000, &start)); why is this returning ...
11 years, 6 months ago (2009-06-23 02:49:07 UTC) #2
rvargas (doing something else)
http://codereview.chromium.org/146005/diff/1/4 File net/disk_cache/entry_unittest.cc (right): http://codereview.chromium.org/146005/diff/1/4#newcode1024 Line 1024: EXPECT_EQ(kSize, entry->GetAvailableRange(0, 0x2100000, &start)); GetAvailableRange returns the number ...
11 years, 6 months ago (2009-06-23 02:59:24 UTC) #3
Nicolas Sylvain
11 years, 6 months ago (2009-06-23 21:53:23 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698