Issue 146003006: Revert broken ArrayPop changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146003006: Revert broken ArrayPop changes (Closed)

Created:
6 years, 11 months ago by Jakob Kummerow

Modified:
6 years, 11 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert broken ArrayPop changes This reverts: r18749 "Reland (and fix) "Add hydrogen support for ArrayPop, and remove the handwritten call stubs."", r18790 "Remove ArrayPush from the custom call generators, and instead call directly to the handler in crankshaft.", and r18798 "MIPS: Remove ArrayPush from the custom call generators, and instead call directly to the handler in crankshaft." For causing crashes on Canary. BUG=chromium:337686 LOG=N R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18805

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+362 lines, -182 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 chunk	+73 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+0 lines, -82 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+70 lines, -0 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1 chunk	+72 lines, -0 lines	0 comments	Download
M	src/stub-cache.h	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View	3 chunks	+57 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 chunk	+71 lines, -0 lines	0 comments	Download
M	test/mjsunit/object-seal.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
D	test/mjsunit/regress/regress-array-pop-deopt.js	View	1 chunk	+0 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

6 years, 11 months ago (2014-01-24 08:33:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18805 (presubmit successful).

Expand Messages | Collapse Messages