Bindings for CSSOM View smooth scroll API

Source/bindings/v8/custom/V8WindowCustom.cpp

 /*
  * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "V8Window.h"
 
+#include "RuntimeEnabledFeatures.h"
 #include "V8HTMLCollection.h"
 #include "V8Node.h"
 #include "bindings/v8/BindingSecurity.h"
 #include "bindings/v8/ExceptionMessages.h"
 #include "bindings/v8/ExceptionState.h"
 #include "bindings/v8/ScheduledAction.h"
 #include "bindings/v8/ScriptController.h"
 #include "bindings/v8/ScriptSourceCode.h"
 #include "bindings/v8/SerializedScriptValue.h"
 #include "bindings/v8/V8Binding.h"
@@ skipping 335 matching lines @@
     }
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, windowFeaturesString, info[2]);
 
     RefPtr<DOMWindow> openedWindow = impl->open(urlString, frameName, windowFeaturesString, activeDOMWindow(), firstDOMWindow());
     if (!openedWindow)
         return;
 
     v8SetReturnValueFast(info, openedWindow.release(), impl);
 }
 
+void V8Window::scrollByMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

[haraken, 2014/01/27 01:44:13]

Ditto. Can't you avoid writing custom bindings by adding some helper methods in
core/ ?

[ajuma, 2014/01/27 02:07:00]

The problem is that specifying that a particular argument is runtime-enabled
doesn't seem to be supported right now. So when I tried this approach (that is,
adding code in core/ to ignore the third argument when the runtime flag is
disabled), the issue I ran into was that the type of the third argument was
being checked even when the runtime flag is disabled, which means that a call
like "window.scrollTo(1,2,3)" which works on ToT (since "3" is ignored) will
throw an error, even when the runtime flag is disabled.

[haraken, 2014/01/27 02:30:48]

Probably we want to improve code_generator_v8.pm so that it can support
[RuntimeEnabled] on function arguments?

I understand your pain --- it's a tough task to improve the code generator.
However, adding more custom bindings leads to more bugs, so it seems to me it's
a right thing to do here.

[Nils Barth (inactive), 2014/01/27 05:23:45]

Ow! (>.<)
That's in principle possible, but would be really confusing:
the code inside the method would need to check RuntimeEnabled,
which get v. confusing and would add huge complexity to the CG.

Much simpler would be to just have two methods and use overloading, with the
second one RuntimeEnabled:
void a(x, y);
[RuntimeEnabled=Foo] void a(x, y, z);

This should work, and if not, it would be rather easier to extend the CG to
support this case.

Docs:
http://www.chromium.org/blink/webidl/blink-idl-extended-attributes#TOC-Overlo...

+{
+    ExceptionState exceptionState(ExceptionState::ExecutionContext, "scrollBy", "Window", info.Holder(), info.GetIsolate());
+    if (UNLIKELY(info.Length() < 2)) {
+        exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(2, info.Length()));
+        exceptionState.throwIfNeeded();
+        return;
+    }
+    DOMWindow* impl = V8Window::toNative(info.Holder());
+    if (!BindingSecurity::shouldAllowAccessToFrame(impl->frame(), exceptionState)) {
+        exceptionState.throwIfNeeded();
+        return;
+    }
+    V8TRYCATCH_EXCEPTION_VOID(int, x, toInt32(info[0], exceptionState), exceptionState);
+    V8TRYCATCH_EXCEPTION_VOID(int, y, toInt32(info[1], exceptionState), exceptionState);
+
+    if (info.Length() >= 3 && RuntimeEnabledFeatures::cssomSmoothScrollEnabled()) {
+        V8TRYCATCH_VOID(Dictionary, scrollOptions, Dictionary(info[2], info.GetIsolate()));
+        impl->scrollBy(x, y, scrollOptions, exceptionState);
+    } else {
+        impl->scrollBy(x, y, Dictionary(), exceptionState);
+    }
+    exceptionState.throwIfNeeded();
+}
+
+void V8Window::scrollToMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
+{
+    ExceptionState exceptionState(ExceptionState::ExecutionContext, "scrollTo", "Window", info.Holder(), info.GetIsolate());
+    if (UNLIKELY(info.Length() < 2)) {
+        exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(2, info.Length()));
+        exceptionState.throwIfNeeded();
+        return;
+    }
+    DOMWindow* impl = V8Window::toNative(info.Holder());
+    if (!BindingSecurity::shouldAllowAccessToFrame(impl->frame(), exceptionState)) {
+        exceptionState.throwIfNeeded();
+        return;
+    }
+    V8TRYCATCH_EXCEPTION_VOID(int, x, toInt32(info[0], exceptionState), exceptionState);
+    V8TRYCATCH_EXCEPTION_VOID(int, y, toInt32(info[1], exceptionState), exceptionState);
+
+    if (info.Length() >= 3 && RuntimeEnabledFeatures::cssomSmoothScrollEnabled()) {
+        V8TRYCATCH_VOID(Dictionary, scrollOptions, Dictionary(info[2], info.GetIsolate()));
+        impl->scrollTo(x, y, scrollOptions, exceptionState);
+    } else {
+        impl->scrollTo(x, y, Dictionary(), exceptionState);
+    }
+    exceptionState.throwIfNeeded();
+}
+
+void V8Window::scrollMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
+{
+    ExceptionState exceptionState(ExceptionState::ExecutionContext, "scroll", "Window", info.Holder(), info.GetIsolate());
+    if (UNLIKELY(info.Length() < 2)) {
+        exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(2, info.Length()));
+        exceptionState.throwIfNeeded();
+        return;
+    }
+    DOMWindow* impl = V8Window::toNative(info.Holder());
+    if (!BindingSecurity::shouldAllowAccessToFrame(impl->frame(), exceptionState)) {
+        exceptionState.throwIfNeeded();
+        return;
+    }
+    V8TRYCATCH_EXCEPTION_VOID(int, x, toInt32(info[0], exceptionState), exceptionState);
+    V8TRYCATCH_EXCEPTION_VOID(int, y, toInt32(info[1], exceptionState), exceptionState);
+
+    if (info.Length() >= 3 && RuntimeEnabledFeatures::cssomSmoothScrollEnabled()) {
+        V8TRYCATCH_VOID(Dictionary, scrollOptions, Dictionary(info[2], info.GetIsolate()));
+        impl->scroll(x, y, scrollOptions, exceptionState);
+    } else {
+        impl->scroll(x, y, Dictionary(), exceptionState);
+    }
+    exceptionState.throwIfNeeded();
+}
+
 void V8Window::namedPropertyGetterCustom(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
 {
 
     DOMWindow* window = V8Window::toNative(info.Holder());
     if (!window)
         return;
 
     Frame* frame = window->frame();
     // window is detached from a frame.
     if (!frame)
@@ skipping 151 matching lines @@
     v8::Handle<v8::Context> context = frame->script().currentWorldContextOrMainWorldContext();
     if (context.IsEmpty())
         return v8Undefined();
 
     v8::Handle<v8::Object> global = context->Global();
     ASSERT(!global.IsEmpty());
     return global;
 }
 
 } // namespace WebCore