views/mus: Fix showing menu in chrome in mus.

views/mus: Fix showing menu in chrome in mus.

For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
window. For desktop builds, this means we attempt to host in a HWND or an
X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
NativeWidgetMus. To do this, use the native-widget factory first if it's
available.

BUG=none

Committed: https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971
Cr-Commit-Position: refs/heads/master@{#361151}

R=jam@chromium.org, sky@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/cf536a3c19f5bd23c2a182864cb1233f71521cdb

[sadrul, 2015-11-20 02:44:39]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2015-11-20 02:44:39]

I kind of dislike the ScopedAllowWait in WindowManagerConnection. I think it'd
be better if we could get away with DONT_WAIT_FOR_EMBED (I am looking at if
that'd be possible now).

But otherwise, does this look like the right thing to do?

[sky, 2015-11-20 16:07:23]

LGTM

[sadrul, 2015-11-20 18:15:49]

sadrul@chromium.org changed reviewers:
+ jam@chromium.org

[sadrul, 2015-11-20 18:15:49]

+jam@ for the use of ScopedAllowWait in WindowManagerConnection.

[jam, 2015-11-23 17:01:41]

lgtm

[sadrul, 2015-11-23 17:15:14]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2015-11-23 17:15:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1460003004/#ps20001
(title: "")

[commit-bot: I haz the power, 2015-11-23 17:16:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460003004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460003004/20001

[commit-bot: I haz the power, 2015-11-23 19:25:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-23 19:26:56]

Patchset 2 (id:??) landed as
https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971
Cr-Commit-Position: refs/heads/master@{#361151}

[beaudoin, 2015-11-23 20:07:28]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1472873003/ by beaudoin@chromium.org.

The reason for reverting is: Suspected in build failure. see crbug.com/560461.

[sadrul, 2015-11-23 23:08:43]

Description was changed from

==========
views/mus: Fix showing menu in chrome in mus.

For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
window. For desktop builds, this means we attempt to host in a HWND or an
X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
NativeWidgetMus. To do this, use the native-widget factory first if it's
available.

BUG=none

Committed: https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971
Cr-Commit-Position: refs/heads/master@{#361151}
==========

to

==========
views/mus: Fix showing menu in chrome in mus.

For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
window. For desktop builds, this means we attempt to host in a HWND or an
X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
NativeWidgetMus. To do this, use the native-widget factory first if it's
available.

BUG=none

Committed: https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971
Cr-Commit-Position: refs/heads/master@{#361151}
==========

[sadrul, 2015-11-23 23:11:01]

On 2015/11/23 20:07:28, beaudoin wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1472873003/ by mailto:beaudoin@chromium.org.
> 
> The reason for reverting is: Suspected in build failure. see crbug.com/560461.

Took the friend declaration outside of the OFFICIAL_BUILD define to fix official
builds. Putting it back in the CQ with that fix.

[sadrul, 2015-11-23 23:11:10]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2015-11-23 23:11:10]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1460003004/#ps40001
(title: "fix-official-build")

[commit-bot: I haz the power, 2015-11-23 23:12:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460003004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460003004/40001

[commit-bot: I haz the power, 2015-11-24 01:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 01:51:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2015-11-24 05:00:36]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2015-11-24 05:03:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460003004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460003004/40001

[commit-bot: I haz the power, 2015-11-24 06:55:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 06:56:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2015-11-24 07:41:39]

Patchset 3 (id:??) landed as
https://crrev.com/cf536a3c19f5bd23c2a182864cb1233f71521cdb
Cr-Commit-Position: refs/heads/master@{#361271}

[sadrul, 2015-11-24 07:42:04]

Committed patchset #3 (id:40001) manually as
cf536a3c19f5bd23c2a182864cb1233f71521cdb (presubmit successful).