Fix race condition in jump table list creation

Fix race condition in jump table list creation

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0fe6b5448002000c97eccc62e02a4a73e15a9e9a

[sehr, 2015-11-20 00:42:11]

Description was changed from

==========
Fix race condition in jump table list creation

BUG=
==========

to

==========
Fix race condition in jump table list creation

BUG=
==========

[sehr, 2015-11-20 00:42:11]

sehr@chromium.org changed reviewers:
+ stichnot@chromium.org

[sehr, 2015-11-20 00:42:49]

I think it just needs to create the whole entry, then insert it in the list as
one, and we avoid the race condition.  WDYT?

[Jim Stichnoth, 2015-11-20 01:02:20]

LGTM, thanks!

https://codereview.chromium.org/1460003003/diff/1/src/IceSwitchLowering.h
File src/IceSwitchLowering.h (right):

https://codereview.chromium.org/1460003003/diff/1/src/IceSwitchLowering.h#new...
src/IceSwitchLowering.h:86: JumpTableData(IceString FuncName, SizeT Id, const
TargetList &TargetOffsets)
const IceString &FuncName

https://codereview.chromium.org/1460003003/diff/1/src/IceSwitchLowering.h#new...
src/IceSwitchLowering.h:101: IceString FuncName;
Can this be const IceString?

[sehr, 2015-11-20 05:43:15]

Thanks for the review.  Waiting for check-presubmit.

https://codereview.chromium.org/1460003003/diff/1/src/IceSwitchLowering.h
File src/IceSwitchLowering.h (right):

https://codereview.chromium.org/1460003003/diff/1/src/IceSwitchLowering.h#new...
src/IceSwitchLowering.h:86: JumpTableData(IceString FuncName, SizeT Id, const
TargetList &TargetOffsets)
On 2015/11/20 01:02:20, stichnot wrote:
> const IceString &FuncName

Done.

https://codereview.chromium.org/1460003003/diff/1/src/IceSwitchLowering.h#new...
src/IceSwitchLowering.h:101: IceString FuncName;
On 2015/11/20 01:02:20, stichnot wrote:
> Can this be const IceString?

Looks like move operations don't work if I do this.

[sehr, 2015-11-20 05:47:20]

Committed patchset #2 (id:20001) manually as
0fe6b5448002000c97eccc62e02a4a73e15a9e9a (presubmit successful).