Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: media/audio/audio_output_controller.h

Issue 14600025: Replace AudioSilenceDetector with an AudioPowerMonitor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: audio_power_monitor_unittest.cc compile fixes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_controller.h
diff --git a/media/audio/audio_output_controller.h b/media/audio/audio_output_controller.h
index dddb90e368ef25fd02155a30bc392dd27d09d895..d1f3dee3e2f89cda3e526a396244dfd80b61881e 100644
--- a/media/audio/audio_output_controller.h
+++ b/media/audio/audio_output_controller.h
@@ -52,7 +52,7 @@
namespace media {
-class AudioSilenceDetector;
+class AudioPowerMonitor;
Chris Rogers 2013/07/18 00:09:36 sss
class MEDIA_EXPORT AudioOutputController
: public base::RefCountedThreadSafe<AudioOutputController>,
@@ -66,7 +66,7 @@ class MEDIA_EXPORT AudioOutputController
public:
virtual void OnCreated() = 0;
virtual void OnPlaying() = 0;
- virtual void OnAudible(bool is_audible) = 0;
+ virtual void OnPowerMeasured(float power_dbfs, bool clipped) = 0;
virtual void OnPaused() = 0;
virtual void OnError() = 0;
virtual void OnDeviceChange(int new_buffer_size, int new_sample_rate) = 0;
@@ -234,9 +234,9 @@ class MEDIA_EXPORT AudioOutputController
int number_polling_attempts_left_;
// Scans audio samples from OnMoreIOData() as input and causes
- // EventHandler::OnAudbile() to be called whenever a transition to a period of
- // silence or non-silence is detected.
- scoped_ptr<AudioSilenceDetector> silence_detector_;
+ // EventHandler::OnPowerMeasured() to be called with power level measurements
+ // at regular intervals.
+ scoped_ptr<AudioPowerMonitor> power_monitor_;
DISALLOW_COPY_AND_ASSIGN(AudioOutputController);
};

Powered by Google App Engine
This is Rietveld 408576698