[Cronet] Continue UrlRequest with NULL certificate if Client cert is requested.

components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.os.ConditionVariable;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.test.util.Feature;
@@ skipping 536 matching lines @@
         assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
         assertEquals(0, callback.mResponseInfo.getReceivedBytesCount());
         assertNotNull(callback.mError);
         assertEquals(arbitraryNetError, callback.mError.netError());
         assertEquals(0, callback.mRedirectCount);
         assertTrue(callback.mOnErrorCalled);
         assertEquals(callback.mResponseStep, ResponseStep.ON_RESPONSE_STARTED);
     }
 
     /**
+     * Tests that request continues when client certificate is requested and the
+     * |arbitraryNetError| is reported later.
+     */
+    @SmallTest
+    @Feature({"Cronet"})
+    public void testMockCertRequested() throws Exception {
+        final int arbitraryNetError = -606;

[xunjieli, 2015/11/20 21:04:25]

nit: unused, and in comment.

[mef, 2015/11/20 22:01:23]

Done.

+        TestUrlRequestCallback callback = startAndWaitForComplete(
+                MockUrlRequestJobFactory.getMockUrlForClientCertificateRequest());
+        assertNotNull(callback.mResponseInfo);

[xunjieli, 2015/11/20 21:04:25]

Maybe assert on getHttpStatusCode and mResponseAsString.

[mef, 2015/11/20 22:01:23]

Done.

+        assertEquals(0, callback.mRedirectCount);
+        assertNull(callback.mError);
+        assertFalse(callback.mOnErrorCalled);
+    }
+
+    /**
      * Tests that an SSL cert error will be reported via {@link UrlRequest#onFailed}.
      */
     @SmallTest
     @Feature({"Cronet"})
     public void testMockSSLCertificateError() throws Exception {
         TestUrlRequestCallback callback = startAndWaitForComplete(
                 MockUrlRequestJobFactory.getMockUrlForSSLCertificateError());
         assertNull(callback.mResponseInfo);
         assertNotNull(callback.mError);
         assertTrue(callback.mOnErrorCalled);
@@ skipping 992 matching lines @@
             int end) {
         // Use a duplicate to avoid modifying byteBuffer.
         ByteBuffer duplicate = byteBuffer.duplicate();
         duplicate.position(start);
         duplicate.limit(end);
         byte[] contents = new byte[duplicate.remaining()];
         duplicate.get(contents);
         return new String(contents);
     }
 }