Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1459973005: Reland of Use std::tie() for operator< in components/ (Closed)

Created:
5 years, 1 month ago by jsbell
Modified:
5 years, 1 month ago
CC:
jochen (gone - plz use gerrit), bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, jdonnelly+autofillwatch_chromium.org, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, rjkroege, rouslan+autofill_chromium.org, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Use std::tie() for operator< in components/ (patchset #1 id:1 of https://codereview.chromium.org/1456263005/ ) Reason for revert: Did not resolve perf regression, so re-landing. Original issue's description: > Revert of Use std::tie() for operator< in components/ (patchset #1 id:1 of https://codereview.chromium.org/1447153002/ ) > > Reason for revert: > Perf regression? Shouldn't be, but let's check. https://crbug.com/558616 > > Original issue's description: > > Use std::tie() for operator< in components/ > > > > Simplify the code for operator< when comparing multiple members using > > a common std::tie idiom. > > > > BUG=555171 > > R=thakis@chromium.org,vabr@chromium.org,jochen@chromium.org > > > > Committed: https://crrev.com/4afb256b17b1c9a716a031205f48f4648768c308 > > Cr-Commit-Position: refs/heads/master@{#360367} > > TBR=jochen@chromium.org,thakis@chromium.org,vabr@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=555171 > > Committed: https://crrev.com/0a0c449a5af92bdca0e37d539617e9d4dffae220 > Cr-Commit-Position: refs/heads/master@{#360707} TBR=jochen@chromium.org,thakis@chromium.org,vabr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555171 Committed: https://crrev.com/dd1a3ea18cc2301d7d6a6a7b5058216b4883bd3a Cr-Commit-Position: refs/heads/master@{#360868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -55 lines) Patch
M components/autofill/core/common/form_data.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M components/autofill/core/common/form_field_data.cc View 2 chunks +9 lines, -21 lines 0 comments Download
M components/autofill/core/common/password_form_fill_data.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/content_settings/core/browser/content_settings_origin_identifier_value_map.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M components/guest_view/browser/guest_view_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/ids.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/policy_namespace.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/url_matcher/string_pattern.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jsbell
Created Reland of Use std::tie() for operator< in components/
5 years, 1 month ago (2015-11-20 19:00:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459973005/1
5 years, 1 month ago (2015-11-20 19:05:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 19:07:49 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 19:08:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd1a3ea18cc2301d7d6a6a7b5058216b4883bd3a
Cr-Commit-Position: refs/heads/master@{#360868}

Powered by Google App Engine
This is Rietveld 408576698