Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1459973003: Remove ScopedVector from spdy_stream (Closed)

Created:
5 years, 1 month ago by Olli Raula
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from spdy_stream BUG=554289 Committed: https://crrev.com/5c5d0576e080c8340a2b0b08efcd517380467e18 Cr-Commit-Position: refs/heads/master@{#361077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M net/spdy/spdy_stream.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/spdy/spdy_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Olli Raula
could you review?
5 years, 1 month ago (2015-11-20 16:07:05 UTC) #3
Ryan Hamilton
lgtm
5 years, 1 month ago (2015-11-20 23:30:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459973003/1
5 years, 1 month ago (2015-11-23 07:16:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 08:28:36 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 08:29:21 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5c5d0576e080c8340a2b0b08efcd517380467e18
Cr-Commit-Position: refs/heads/master@{#361077}

Powered by Google App Engine
This is Rietveld 408576698