third_party/WebKit/Source/core/paint/FilterPainter.cpp - Issue 1459953002: Fix the reference box computation for CSS filter effects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FilterPainter.cpp

Issue 1459953002: Fix the reference box computation for CSS filter effects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TODO per review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FilterPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/FilterPainter.cpp b/third_party/WebKit/Source/core/paint/FilterPainter.cpp

index 618338860f0336c08dca839cec9d29e3df4102ad..cc14063934468c50812b25e92c576382a6271f38 100644

--- a/third_party/WebKit/Source/core/paint/FilterPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/FilterPainter.cpp

@@ -27,13 +27,16 @@ FilterPainter::FilterPainter(PaintLayer& layer, GraphicsContext* context, const

, m_context(context)

, m_layoutObject(layer.layoutObject())

{

- if (!layer.filterEffectBuilder() || !layer.paintsWithFilters())

+ if (!layer.paintsWithFilters())

+ return;

+ RefPtrWillBeRawPtr<FilterEffect> lastEffect = layer.lastFilterEffect();

+ if (!lastEffect)

return;

ASSERT(layer.filterInfo());

SkiaImageFilterBuilder builder;

- RefPtrWillBeRawPtr<FilterEffect> lastEffect = layer.filterEffectBuilder()->lastEffect();

lastEffect->determineFilterPrimitiveSubregion(MapRectForward);

RefPtr<SkImageFilter> imageFilter = builder.build(lastEffect.get(), ColorSpaceDeviceRGB);

if (!imageFilter)