Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1459943002: Clip abspos descendants correctly in all columns (not just the first). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review - possible alternative Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 04df0409cb18e2abbfa6fd7ce834aec01114fa0f..f18a5344aa3074c7797d855b9e7077ba89012fa8 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -1691,18 +1691,8 @@ LayoutSize LayoutBox::offsetFromContainer(const LayoutObject* o, const LayoutPoi
if (isInFlowPositioned())
offset += offsetForInFlowPosition();
- if (!isInline() || isReplaced()) {
+ if (!isInline() || isReplaced())
offset += topLeftLocationOffset();
- if (o->isLayoutFlowThread()) {
- // So far the point has been in flow thread coordinates (i.e. as if everything in
- // the fragmentation context lived in one tall single column). Convert it to a
- // visual point now.
- LayoutPoint pointInContainer = point + offset;
- offset += o->columnOffset(pointInContainer);
- if (offsetDependsOnPoint)
- *offsetDependsOnPoint = true;
- }
- }
if (o->hasOverflowClip())
offset -= toLayoutBox(o)->scrolledContentOffset();

Powered by Google App Engine
This is Rietveld 408576698