Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1459933002: Avoid implicit size_t conversions on setting HeapObjectHeader::m_encoded. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid implicit size_t conversions on setting HeapObjectHeader::m_encoded. Cannot assume that sizeof(size_t) matches that of uint32_t. R= BUG= Committed: https://crrev.com/89e2fb3f209cea22b85819b078e98b92725d148b Cr-Commit-Position: refs/heads/master@{#360703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapPage.h View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. cf. compile failures on win64 bot -- http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/67322/steps/compile/logs/stdio
5 years, 1 month ago (2015-11-19 16:06:26 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-19 23:16:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459933002/1
5 years, 1 month ago (2015-11-19 23:19:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 01:19:17 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 01:20:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89e2fb3f209cea22b85819b078e98b92725d148b
Cr-Commit-Position: refs/heads/master@{#360703}

Powered by Google App Engine
This is Rietveld 408576698