Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: media/base/moving_average_unittest.cc

Issue 1459923003: Fix Bug: Video with Variable Frame Rate plays at incorrect speed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/moving_average.cc ('k') | media/filters/video_cadence_estimator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/moving_average_unittest.cc
diff --git a/media/base/moving_average_unittest.cc b/media/base/moving_average_unittest.cc
index da8e51922d8912bb50398fe7e7c51cd0c5afe1ea..39ad094231ae207c55f3606786e0976fdc687685 100644
--- a/media/base/moving_average_unittest.cc
+++ b/media/base/moving_average_unittest.cc
@@ -8,19 +8,30 @@
namespace media {
-TEST(MovingAverageTest, Average) {
+TEST(MovingAverageTest, AverageAndDeviation) {
const int kSamples = 5;
MovingAverage moving_average(kSamples);
moving_average.AddSample(base::TimeDelta::FromSeconds(1));
EXPECT_EQ(base::TimeDelta::FromSeconds(1), moving_average.Average());
+ EXPECT_EQ(base::TimeDelta(), moving_average.Deviation());
+
for (int i = 0; i < kSamples - 1; ++i)
moving_average.AddSample(base::TimeDelta::FromSeconds(1));
EXPECT_EQ(base::TimeDelta::FromSeconds(1), moving_average.Average());
+ EXPECT_EQ(base::TimeDelta(), moving_average.Deviation());
+ base::TimeDelta expect_deviation[] = {
+ base::TimeDelta::FromMicroseconds(200000),
+ base::TimeDelta::FromMicroseconds(244948),
+ base::TimeDelta::FromMicroseconds(244948),
+ base::TimeDelta::FromMicroseconds(200000),
+ base::TimeDelta::FromMilliseconds(0),
+ };
for (int i = 0; i < kSamples; ++i) {
moving_average.AddSample(base::TimeDelta::FromMilliseconds(500));
EXPECT_EQ(base::TimeDelta::FromMilliseconds(1000 - (i + 1) * 100),
moving_average.Average());
+ EXPECT_EQ(expect_deviation[i], moving_average.Deviation());
}
}
@@ -31,6 +42,7 @@ TEST(MovingAverageTest, Reset) {
moving_average.Reset();
moving_average.AddSample(base::TimeDelta());
EXPECT_EQ(base::TimeDelta(), moving_average.Average());
+ EXPECT_EQ(base::TimeDelta(), moving_average.Deviation());
}
} // namespace media
« no previous file with comments | « media/base/moving_average.cc ('k') | media/filters/video_cadence_estimator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698