Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1459843004: X87: Introduce a BuiltinsConstructStub that sets up new.target and does a [[call]] per ES6 9.3.2. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Introduce a BuiltinsConstructStub that sets up new.target and does a [[call]] per ES6 9.3.2. port 469d9bfa8de49477dc4222ef9e0eb7d3d0d43d36 (r32120) original commit message: BUG= Committed: https://crrev.com/313ff5c87f0c0725a17bb0ca445b3bbc453c8a48 Cr-Commit-Position: refs/heads/master@{#32129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -232 lines) Patch
M src/x87/builtins-x87.cc View 4 chunks +198 lines, -232 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-20 02:45:18 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-20 02:50:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459843004/1
5 years, 1 month ago (2015-11-20 02:50:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 03:08:25 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 03:08:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/313ff5c87f0c0725a17bb0ca445b3bbc453c8a48
Cr-Commit-Position: refs/heads/master@{#32129}

Powered by Google App Engine
This is Rietveld 408576698