Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1459823003: add --write option to dump_record (Closed)

Created:
5 years, 1 month ago by reed1
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add --write option to dump_record BUG=skia: Committed: https://skia.googlesource.com/skia/+/ff53af85f61327413adc7c32f0699132b60075a7

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix int->float warning #

Patch Set 4 : I SO NEED to see these warnings on the mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M tools/dump_record.cpp View 1 2 3 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
reed1
ptal
5 years, 1 month ago (2015-11-19 15:46:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459823003/20001
5 years, 1 month ago (2015-11-19 15:47:23 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-19 15:47:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4397)
5 years, 1 month ago (2015-11-19 15:49:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459823003/40001
5 years, 1 month ago (2015-11-19 15:53:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/4339)
5 years, 1 month ago (2015-11-19 15:55:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459823003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459823003/60001
5 years, 1 month ago (2015-11-19 16:03:21 UTC) #14
mtklein
lgtm
5 years, 1 month ago (2015-11-19 16:11:36 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:18:06 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ff53af85f61327413adc7c32f0699132b60075a7

Powered by Google App Engine
This is Rietveld 408576698