| OLD | NEW |
|---|
| (Empty) |
| 1 # Becoming a V8 committer | |
| 2 | |
| 3 ## What is a committer? | |
| 4 | |
| 5 Technically, a committer is someone who has write access to the V8 Git repositor
y. A committer can submit his or her own patches or patches from others. | |
| 6 | |
| 7 This privilege is granted with some expectation of responsibility: committers ar
e people who care about the V8 project and want to help meet its goals. A commit
ter is not just someone who can make changes, but someone who has demonstrated h
is or her ability to collaborate with the team, get the most knowledgeable peopl
e to review code, contribute high-quality code, and follow through to fix issues
(in code or tests). | |
| 8 | |
| 9 A committer is a contributor to the V8 projects' success and a citizen helping t
he projects succeed. See V8CommittersResponsibility. | |
| 10 | |
| 11 ## How do I become a committer? | |
| 12 | |
| 13 In a nutshell, contribute 20 non-trivial patches and get at least three differen
t people to review them (you'll need three people to support you). Then ask some
one to nominate you. You're demonstrating your: | |
| 14 | |
| 15 * commitment to the project (20 good patches requires a lot of your valuable t
ime), | |
| 16 * ability to collaborate with the team, | |
| 17 * understanding of how the team works (policies, processes for testing and cod
e review, etc), | |
| 18 * understanding of the projects' code base and coding style, and | |
| 19 * ability to write good code (last but certainly not least) | |
| 20 | |
| 21 A current committer nominates you by sending email to v8-committers@googlegroups
.com containing: | |
| 22 | |
| 23 * your first and last name | |
| 24 * your Google Code email address | |
| 25 * an explanation of why you should be a committer, | |
| 26 * embedded list of links to revisions (about top 10) containing your patches | |
| 27 | |
| 28 Two other committers need to second your nomination. If no one objects in 5 work
ing days (U.S.), you're a committer. If anyone objects or wants more informatio
n, the committers discuss and usually come to a consensus (within the 5 working
days). If issues cannot be resolved, there's a vote among current committers. | |
| 29 | |
| 30 Once you get approval from the existing committers, we'll send you instructions
for write access to SVN or Git. You'll also be added to v8-committers@googlegrou
ps.com. | |
| 31 | |
| 32 In the worst case, this can drag out for two weeks. Keep writing patches! Even i
n the rare cases where a nomination fails, the objection is usually something ea
sy to address like "more patches" or "not enough people are familiar with this p
erson's work." | |
| 33 | |
| 34 ## Maintaining committer status | |
| 35 | |
| 36 You don't really need to do much to maintain committer status: just keep being a
wesome and helping the V8 project! | |
| 37 | |
| 38 In the unhappy event that a committer continues to disregard good citizenship (o
r actively disrupts the project), we may need to revoke that person's status. Th
e process is the same as for nominating a new committer: someone suggests the re
vocation with a good reason, two people second the motion, and a vote may be cal
led if consensus cannot be reached. I hope that's simple enough, and that we nev
er have to test it in practice. | |
| 39 | |
| 40 (Source: inspired by http://dev.chromium.org/getting-involved/become-a-committer
) | |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 1459823002:
[Docs] Removed unused docs because they are moved to GitHub (Closed)
Base URL: https://chromium.googlesource.com/v8/v8.git@master