Source/core/page/EventHandler.cpp - Issue 14598021: Correct the (x, y) position of dragstart event initiated by touch event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 14598021: Correct the (x, y) position of dragstart event initiated by touch event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html ('K') | « LayoutTests/fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 9a339bd89785e8814b5d0b6361fd02a41df373d4..9d6f3418923e4bc6280ce995af0bed9d121af191 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -2403,6 +2403,10 @@ bool EventHandler::handleGestureLongPress(const PlatformGestureEvent& gestureEve

m_longTapShouldInvokeContextMenu = false;

if (m_frame->settings() && m_frame->settings()->touchDragDropEnabled() && m_frame->view()) {

+ PlatformMouseEvent mouseDownEvent(adjustedPoint, gestureEvent.globalPosition(), LeftButton, PlatformEvent::MousePressed, 1,

+ gestureEvent.shiftKey(), gestureEvent.ctrlKey(), gestureEvent.altKey(), gestureEvent.metaKey(), WTF::currentTime());

+ m_mouseDown = mouseDownEvent;

PlatformMouseEvent mouseDragEvent(adjustedPoint, gestureEvent.globalPosition(), LeftButton, PlatformEvent::MouseMoved, 1,

gestureEvent.shiftKey(), gestureEvent.ctrlKey(), gestureEvent.altKey(), gestureEvent.metaKey(), WTF::currentTime());

HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::DisallowShadowContent);