Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1459793002: Android: Allow compiling browser without Java UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 2af8a6ac8e364251495a810f4adb23fd3ef3cbf3..1a49fd9a1347375c5b32e22c56d0a7f41c96a6c0 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -53,11 +53,11 @@
#include "net/base/url_util.h"
#include "third_party/re2/re2/re2.h"
-#if defined(OS_MACOSX) || defined(OS_ANDROID)
+#if defined(OS_MACOSX) || defined(ANDROID_JAVA_UI)
#include "chrome/browser/password_manager/save_password_infobar_delegate.h"
#endif
-#if defined(OS_ANDROID)
+#if defined(ANDROID_JAVA_UI)
#include "chrome/browser/android/tab_android.h"
#include "chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.h"
#include "chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.h"
@@ -227,7 +227,7 @@ bool ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass());
}
} else {
-#if defined(OS_MACOSX) || defined(OS_ANDROID)
+#if defined(OS_MACOSX) || defined(ANDROID_JAVA_UI)
if (form_to_save->IsBlacklisted())
return false;
std::string uma_histogram_suffix(
@@ -262,7 +262,7 @@ void ChromePasswordManagerClient::ForceSavePassword() {
void ChromePasswordManagerClient::NotifyUserAutoSignin(
ScopedVector<autofill::PasswordForm> local_forms) {
DCHECK(!local_forms.empty());
-#if defined(OS_ANDROID)
+#if defined(ANDROID_JAVA_UI)
ShowAutoSigninPrompt(web_contents(), local_forms[0]->username_value);
#else
ManagePasswordsUIController::FromWebContents(web_contents())->
@@ -273,7 +273,7 @@ void ChromePasswordManagerClient::NotifyUserAutoSignin(
void ChromePasswordManagerClient::AutomaticPasswordSave(
scoped_ptr<password_manager::PasswordFormManager> saved_form) {
-#if defined(OS_ANDROID)
+#if defined(ANDROID_JAVA_UI)
GeneratedPasswordSavedInfoBarDelegateAndroid::Create(web_contents());
#else
if (IsTheHotNewBubbleUIEnabled()) {
@@ -462,7 +462,7 @@ void ChromePasswordManagerClient::GenerationAvailableForForm(
}
bool ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled() {
-#if defined(OS_ANDROID)
+#if defined(ANDROID_JAVA_UI)
return false;
#elif defined(OS_MACOSX)
// Query the group first for correct UMA reporting.

Powered by Google App Engine
This is Rietveld 408576698