Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 1459793002: Android: Allow compiling browser without Java UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index fc1d4165af0c126ad483807c6050d2309f85c3c2..7b8c37248207c232b7a4d23794e7f9198cf864e9 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -182,8 +182,6 @@
#elif defined(OS_LINUX)
#include "chrome/browser/chrome_browser_main_linux.h"
#elif defined(OS_ANDROID)
-#include "chrome/browser/android/new_tab_page_url_handler.h"
-#include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h"
#include "chrome/browser/chrome_browser_main_android.h"
#include "chrome/common/descriptors_android.h"
#include "components/crash/content/browser/crash_dump_manager_android.h"
@@ -200,6 +198,11 @@
#include "components/crash/content/browser/crash_handler_host_linux.h"
#endif
+#if defined(ANDROID_JAVA_UI)
+#include "chrome/browser/android/new_tab_page_url_handler.h"
+#include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h"
+#endif
+
#if defined(OS_ANDROID)
#include "ui/base/ui_base_paths.h"
#include "ui/gfx/android/device_display_info.h"
@@ -582,8 +585,7 @@ class SafeBrowsingSSLCertReporter : public SSLCertReporter {
safe_browsing_ui_manager_;
};
-#if defined(OS_ANDROID)
-
+#if defined(ANDROID_JAVA_UI)
void HandleSingleTabModeBlockOnUIThread(const BlockedWindowParams& params) {
WebContents* web_contents = tab_util::GetWebContentsByFrameID(
params.render_process_id(), params.opener_render_frame_id());
@@ -592,7 +594,9 @@ void HandleSingleTabModeBlockOnUIThread(const BlockedWindowParams& params) {
SingleTabModeTabHelper::FromWebContents(web_contents)->HandleOpenUrl(params);
}
+#endif // defined(ANDROID_JAVA_UI)
+#if defined(OS_ANDROID)
float GetDeviceScaleAdjustment() {
static const float kMinFSM = 1.05f;
static const int kWidthForMinFSM = 320;
@@ -612,7 +616,6 @@ float GetDeviceScaleAdjustment() {
(kWidthForMaxFSM - kWidthForMinFSM);
return ratio * (kMaxFSM - kMinFSM) + kMinFSM;
}
-
#endif // defined(OS_ANDROID)
#if defined(ENABLE_EXTENSIONS)
@@ -2168,7 +2171,7 @@ bool ChromeContentBrowserClient::CanCreateWindow(
}
}
-#if defined(OS_ANDROID)
+#if defined(ANDROID_JAVA_UI)
if (SingleTabModeTabHelper::IsRegistered(render_process_id,
opener_render_view_id)) {
BrowserThread::PostTask(BrowserThread::UI,
@@ -2339,7 +2342,7 @@ void ChromeContentBrowserClient::BrowserURLHandlerCreated(
handler->AddHandlerPair(&WillHandleBrowserAboutURL,
BrowserURLHandler::null_handler());
-#if defined(OS_ANDROID)
+#if defined(ANDROID_JAVA_UI)
// Handler to rewrite chrome://newtab on Android.
handler->AddHandlerPair(&chrome::android::HandleAndroidNativePageURL,
BrowserURLHandler::null_handler());

Powered by Google App Engine
This is Rietveld 408576698