Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1459793002: Android: Allow compiling browser without Java UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index 8548f34333590c5e4efc4761d7e3274e3140108f..83ce9916b215ddfc3e0facc56c0583443a57e139 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -27,7 +27,7 @@
#include "content/public/browser/navigation_details.h"
#include "ui/base/l10n/l10n_util.h"
-#if defined(OS_ANDROID)
+#if BUILDFLAG(ANDROID_JAVA_UI)
#include "chrome/browser/android/chrome_application.h"
#else
#include "chrome/browser/ui/passwords/manage_passwords_icon_view.h"
@@ -149,7 +149,7 @@ void ManagePasswordsUIController::OnLoginsChanged(
UpdateBubbleAndIconVisibility();
}
-#if !defined(OS_ANDROID)
+#if !BUILDFLAG(ANDROID_JAVA_UI)
void ManagePasswordsUIController::UpdateIconAndBubbleState(
ManagePasswordsIconView* icon) {
if (should_pop_up_bubble_) {
@@ -271,7 +271,7 @@ void ManagePasswordsUIController::ChooseCredential(
}
void ManagePasswordsUIController::NavigateToExternalPasswordManager() {
-#if defined(OS_ANDROID)
+#if BUILDFLAG(ANDROID_JAVA_UI)
NOTREACHED();
#else
chrome::NavigateParams params(
@@ -284,7 +284,7 @@ void ManagePasswordsUIController::NavigateToExternalPasswordManager() {
}
void ManagePasswordsUIController::NavigateToSmartLockHelpPage() {
-#if defined(OS_ANDROID)
+#if BUILDFLAG(ANDROID_JAVA_UI)
NOTREACHED();
#else
chrome::NavigateParams params(
@@ -296,7 +296,7 @@ void ManagePasswordsUIController::NavigateToSmartLockHelpPage() {
}
void ManagePasswordsUIController::NavigateToPasswordManagerSettingsPage() {
-#if defined(OS_ANDROID)
+#if BUILDFLAG(ANDROID_JAVA_UI)
chrome::android::ChromeApplication::ShowPasswordSettings();
#else
chrome::ShowSettingsSubPage(
@@ -340,7 +340,7 @@ void ManagePasswordsUIController::UpdateBubbleAndIconVisibility() {
passwords_data_.OnInactive();
}
-#if !defined(OS_ANDROID)
+#if !BUILDFLAG(ANDROID_JAVA_UI)
Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
if (!browser)
return;
@@ -375,14 +375,14 @@ void ManagePasswordsUIController::DidNavigateMainFrame(
}
void ManagePasswordsUIController::WasHidden() {
-#if !defined(OS_ANDROID)
+#if !BUILDFLAG(ANDROID_JAVA_UI)
TabDialogs::FromWebContents(web_contents())->HideManagePasswordsBubble();
#endif
}
void ManagePasswordsUIController::ShowBubbleWithoutUserInteraction() {
DCHECK(should_pop_up_bubble_);
-#if !defined(OS_ANDROID)
+#if !BUILDFLAG(ANDROID_JAVA_UI)
Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
if (!browser || browser->toolbar_model()->input_in_progress())
return;
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698