chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc - Issue 1459793002: Android: Allow compiling browser without Java UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 1459793002: Android: Allow compiling browser without Java UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/credit_card_scanner_view.cc ('k') | chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

index bdc57b8ff23e4b6f603337dd9216a901f5e3a648..bc8b0ea55b556bbaf2a431ff8d3322ecb32b26b3 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

@@ -18,6 +18,7 @@

#include "chrome/browser/ui/autofill/popup_constants.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/chrome_pages.h"

+#include "chrome/common/features.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

@@ -34,7 +35,7 @@

#include "ui/gfx/geometry/rect_conversions.h"

#include "ui/gfx/text_utils.h"

-#if defined(OS_ANDROID)

+#if BUILDFLAG(ANDROID_JAVA_UI)

#include "chrome/browser/android/chrome_application.h"

#endif

@@ -232,7 +233,7 @@ void PasswordGenerationPopupControllerImpl::ViewDestroyed() {

}

void PasswordGenerationPopupControllerImpl::OnSavedPasswordsLinkClicked() {

-#if defined(OS_ANDROID)

+#if BUILDFLAG(ANDROID_JAVA_UI)

chrome::android::ChromeApplication::ShowPasswordSettings();

#else

chrome::ShowSettingsSubPage(