Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4086)

Unified Diff: chrome/browser/bookmarks/bookmark_model_factory.cc

Issue 1459793002: Android: Allow compiling browser without Java UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_model_factory.cc
diff --git a/chrome/browser/bookmarks/bookmark_model_factory.cc b/chrome/browser/bookmarks/bookmark_model_factory.cc
index b4be798b59439e3679e1b4e5a841d97d6a75e639..faef18ced0c990bb8e5ed638b07ea7c9119453f2 100644
--- a/chrome/browser/bookmarks/bookmark_model_factory.cc
+++ b/chrome/browser/bookmarks/bookmark_model_factory.cc
@@ -16,6 +16,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/undo/bookmark_undo_service_factory.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/features.h"
#include "chrome/common/pref_names.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/bookmark_utils.h"
@@ -24,11 +25,11 @@
#include "components/undo/bookmark_undo_service.h"
#include "content/public/browser/browser_thread.h"
-#if defined(OS_ANDROID)
+#if BUILDFLAG(ANDROID_JAVA_UI)
#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
#include "components/offline_pages/offline_page_feature.h"
#include "components/offline_pages/offline_page_model.h"
-#endif // defined(OS_ANDROID)
+#endif // BUILDFLAG(ANDROID_JAVA_UI)
using bookmarks::BookmarkModel;
@@ -56,7 +57,7 @@ BookmarkModelFactory::BookmarkModelFactory()
DependsOn(BookmarkUndoServiceFactory::GetInstance());
DependsOn(ChromeBookmarkClientFactory::GetInstance());
DependsOn(StartupTaskRunnerServiceFactory::GetInstance());
-#if defined(OS_ANDROID)
+#if BUILDFLAG(ANDROID_JAVA_UI)
if (offline_pages::IsOfflinePagesEnabled())
DependsOn(offline_pages::OfflinePageModelFactory::GetInstance());
#endif
@@ -80,20 +81,20 @@ KeyedService* BookmarkModelFactory::BuildServiceInstanceFor(
content::BrowserThread::GetMessageLoopProxyForThread(
content::BrowserThread::UI));
bool register_bookmark_undo_service_as_observer = true;
-#if !defined(OS_IOS) && !defined(OS_ANDROID)
+#if !defined(OS_IOS) && !BUILDFLAG(ANDROID_JAVA_UI)
register_bookmark_undo_service_as_observer =
base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBookmarkUndo);
-#endif // !defined(OS_IOS) && !defined(OS_ANDROID)
+#endif // !defined(OS_IOS) && !BUILDFLAG(ANDROID_JAVA_UI)
if (register_bookmark_undo_service_as_observer)
BookmarkUndoServiceFactory::GetForProfile(profile)->Start(bookmark_model);
-#if defined(OS_ANDROID)
+#if BUILDFLAG(ANDROID_JAVA_UI)
if (offline_pages::IsOfflinePagesEnabled()) {
offline_pages::OfflinePageModelFactory::GetForBrowserContext(profile)->
Start(bookmark_model);
}
-#endif // defined(OS_ANDROID)
+#endif // BUILDFLAG(ANDROID_JAVA_UI)
return bookmark_model;
}
« no previous file with comments | « chrome/browser/background_sync/background_sync_controller_impl.cc ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698