Android: Allow compiling browser without Java UI

chrome/browser/platform_util_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <jni.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/logging.h"
 #include "chrome/browser/platform_util.h"
+#include "url/gurl.h"
+
+#if defined(ANDROID_JAVA_UI)
 #include "jni/PlatformUtil_jni.h"
 #include "ui/android/view_android.h"
-#include "url/gurl.h"
+#endif
 
 namespace platform_util {

[Ted C, 2015/11/30 19:39:05]

To me, it looks like you shouldn't be using this class at at all if
ANDROID_JAVA_UI is set.  You should be probably be using one of the other
existing ones or something new.

[no sievers, 2015/11/30 23:56:34]

Makes sense. Changes reverted.

 
 // TODO: crbug/115682 to track implementation of the following methods.
 
 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) {
   NOTIMPLEMENTED();
 }
 
 void OpenItem(Profile* profile,
               const base::FilePath& full_path,
               OpenItemType item_type,
               const OpenOperationCallback& callback) {
   NOTIMPLEMENTED();
 }
 
 void OpenExternal(Profile* profile, const GURL& url) {
+#if defined(ANDROID_JAVA_UI)
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jstring> j_url =
       base::android::ConvertUTF8ToJavaString(env, url.spec());
   Java_PlatformUtil_launchExternalProtocol(env, j_url.obj());
+#endif
 }
 
 gfx::NativeWindow GetTopLevel(gfx::NativeView view) {
+#if defined(ANDROID_JAVA_UI)
   NOTIMPLEMENTED();
   return view->GetWindowAndroid();
+#else
+  NOTIMPLEMENTED();
+  return nullptr;
+#endif
 }
 
 gfx::NativeView GetParent(gfx::NativeView view) {
   NOTIMPLEMENTED();
   return view;
 }
 
 bool IsWindowActive(gfx::NativeWindow window) {
   NOTIMPLEMENTED();
   return false;
 }
 
 void ActivateWindow(gfx::NativeWindow window) {
   NOTIMPLEMENTED();
 }
 
 bool IsVisible(gfx::NativeView view) {
   NOTIMPLEMENTED();
   return true;
 }
 
+#if defined(ANDROID_JAVA_UI)
 bool RegisterPlatformUtil(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
+#endif
 
 } // namespace platform_util