Android: Allow compiling browser without Java UI

chrome/chrome_browser_ui.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # There are two sections of sources:
     # * "Platform"-based sources (OS, toolkit, etc.)
     # * Feature/directory-based sources (e.g., history, printing)
 
     ### Platform-based sources ###
     'chrome_browser_ui_non_ios_sources': [
       'browser/ui/accelerator_utils.h',
       'browser/ui/android/android_about_app_info.cc',
       'browser/ui/android/android_about_app_info.h',
       'browser/ui/android/external_protocol_dialog_android.cc',
       'browser/ui/android/status_tray_android.cc',

[mfomitchev, 2015/11/19 15:41:05]

Should status_tray_android.cc and android_about_app_info.cc also be moved to
chrome_browser_ui_android_java_ui_sources?

-      'browser/ui/android/tab_model/tab_model_list.cc',
-      'browser/ui/android/tab_model/tab_model_list.h',
       'browser/ui/app_list/app_list_util.cc',
       'browser/ui/app_list/app_list_util.h',
       # All other browser/ui/app_list files go in chrome_browser_ui_app_list_sources.
       'browser/ui/app_modal/chrome_javascript_native_dialog_factory.h',
       'browser/ui/autofill/autofill_dialog_controller.cc',
       'browser/ui/autofill/autofill_dialog_controller.h',
       'browser/ui/autofill/autofill_dialog_models.cc',
       'browser/ui/autofill/autofill_dialog_models.h',
       'browser/ui/autofill/autofill_dialog_types.cc',
       'browser/ui/autofill/autofill_dialog_types.h',
@@ skipping 386 matching lines @@
       'browser/ui/webui/version_handler_chromeos.cc',
       'browser/ui/webui/version_handler_chromeos.h',
       'browser/ui/webui/version_ui.cc',
       'browser/ui/webui/version_ui.h',
       'browser/ui/window_sizer/window_sizer_mac.mm',
       'browser/ui/zoom/chrome_zoom_level_otr_delegate.cc',
       'browser/ui/zoom/chrome_zoom_level_otr_delegate.h',
       'browser/ui/zoom/chrome_zoom_level_prefs.cc',
       'browser/ui/zoom/chrome_zoom_level_prefs.h',
     ],
-    'chrome_browser_ui_android_non_aura_sources': [
+    'chrome_browser_ui_android_java_ui_sources': [

[mfomitchev, 2015/11/19 15:41:05]

This name becomes confusing. There's two "ui"s in the name, but they have
different meaning, and it's hard to understand it, unless you know what's going
on already. We also have chrome_browser_android_java_ui_sources, which could
easily be confused with this source set. Perhaps we should avoid using "java_ui"
in source set names. I don't have any good suggestions, but IMHO even
chrome_browser_ui_android_non_aura_sources was easier to read/understand, even
though it was less accurate.

       'browser/ui/android/autofill/autofill_dialog_controller_android.cc',
       'browser/ui/android/autofill/autofill_dialog_controller_android.h',
       'browser/ui/android/autofill/autofill_dialog_result.cc',
       'browser/ui/android/autofill/autofill_dialog_result.h',
       'browser/ui/android/autofill/autofill_keyboard_accessory_view.cc',
       'browser/ui/android/autofill/autofill_keyboard_accessory_view.h',
       'browser/ui/android/autofill/autofill_logger_android.cc',
       'browser/ui/android/autofill/autofill_logger_android.h',
       'browser/ui/android/autofill/autofill_popup_view_android.cc',
       'browser/ui/android/autofill/autofill_popup_view_android.h',
@@ skipping 48 matching lines @@
       'browser/ui/android/ssl_client_certificate_request.cc',
       'browser/ui/android/ssl_client_certificate_request.h',
       'browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc',
       'browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.h',
       'browser/ui/android/tab_model/single_tab_model.cc',
       'browser/ui/android/tab_model/single_tab_model.h',
       'browser/ui/android/tab_model/tab_model.cc',
       'browser/ui/android/tab_model/tab_model.h',
       'browser/ui/android/tab_model/tab_model_jni_bridge.cc',
       'browser/ui/android/tab_model/tab_model_jni_bridge.h',
+      'browser/ui/android/tab_model/tab_model_list.cc',
+      'browser/ui/android/tab_model/tab_model_list.h',
       'browser/ui/android/website_settings_popup_android.cc',
       'browser/ui/android/website_settings_popup_android.h',
       'browser/ui/android/window_android_helper.cc',
       'browser/ui/android/window_android_helper.h',
       'browser/ui/browser_otr_state_android.cc',
       'browser/ui/screen_capture_notification_ui_stub.cc',
       'browser/ui/webui/popular_sites_internals_message_handler.cc',
       'browser/ui/webui/popular_sites_internals_message_handler.h',
       'browser/ui/webui/popular_sites_internals_ui.cc',
       'browser/ui/webui/popular_sites_internals_ui.h',
@@ skipping 2531 matching lines @@
         }],
         ['enable_print_preview==1', {
           'sources': [ '<@(chrome_browser_ui_print_preview_sources)' ],
         }],
         ['OS=="android"', {
           'dependencies': [
             '../components/components.gyp:web_contents_delegate_android',
             '../third_party/boringssl/boringssl.gyp:boringssl',
             'chrome_browser_jni_headers',
           ],
-          'dependencies!': [
-             '../ui/events/events.gyp:events',
-             'chrome_browser_ui_views.gyp:browser_ui_views',
+          'conditions': [
+            ['android_java_ui == 1', {
+              'sources': [ '<@(chrome_browser_ui_android_java_ui_sources)' ],
+              'dependencies!': [
+                '../ui/events/events.gyp:events',
+                'chrome_browser_ui_views.gyp:browser_ui_views',
+              ],
+            }]
           ],
-          'sources': [ '<@(chrome_browser_ui_android_non_aura_sources)' ],
         }],
         ['OS=="mac"', {
           'sources': [ '<@(chrome_browser_ui_mac_sources)' ],
           'dependencies': [
             '../third_party/apple_sample_code/apple_sample_code.gyp:apple_sample_code',
             '../third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:google_toolbox_for_mac',
             '../third_party/molokocacao/molokocacao.gyp:molokocacao',
             '../third_party/mozilla/mozilla.gyp:mozilla',
           ],
           'conditions': [
@@ skipping 208 matching lines @@
           ],
           'sources': [
             '<@(chrome_browser_ui_non_mobile_sources)',
             '<@(chrome_browser_ui_omnibox_non_mobile_sources)',
           ],
         }],
       ],
     },
   ],
 }