Android: Allow compiling browser without Java UI

build/config/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/allocator.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
@@ skipping 22 matching lines @@
   # generate anything deterministic with WPO enabled AFAIK.
   dont_embed_build_metadata = !is_official_build
 
   # Set to true to enable dcheck in Release builds.
   dcheck_always_on = false
 }
 
 # TODO(brettw) Most of these should be removed. Instead of global feature
 # flags, we should have more modular flags that apply only to a target and its
 # dependents. For example, depending on the "x11" meta-target should define
 # USE_X11 for all dependents so that everything that could use X11 gets the

[no sievers, 2015/11/19 01:14:18]

I'm wondering if it's worth doing that.

For gyp it was also easier to restrict the define to chrome/ (through
chrome_browser_android.gypi) while for GN I couldn't find a good common place
where I wouldn't be scared that some compile target would be missing the
#define.

I'll see if we can at least leverage 'gn check' to make sure the
android_java_ui=0 build does not include headers from java_ui sources.

[no sievers, 2015/11/19 01:26:52]

For 'gn check' to work I *think* I need to specify 'visibility', which I think
works only with targets.

 # define, but anything that doesn't depend on X11 doesn't see it.
 #
 # For now we define these globally to match the current GYP build.
 config("feature_flags") {
   # TODO(brettw) this probably needs to be parameterized.
   defines = [
     "V8_DEPRECATION_WARNINGS",  # Don't use deprecated V8 APIs anywhere.
     "CLD_VERSION=$cld_version",
   ]
   if (enable_mdns) {
     defines += [ "ENABLE_MDNS=1" ]
   }
   if (enable_notifications) {
     defines += [ "ENABLE_NOTIFICATIONS" ]
   }
   if (enable_pepper_cdms) {
     # TODO(brettw) should probably be "=1"
     defines += [ "ENABLE_PEPPER_CDMS" ]
   }
   if (enable_browser_cdms) {
     # TODO(brettw) should probably be "=1"
     defines += [ "ENABLE_BROWSER_CDMS" ]
   }
   if (enable_plugins) {
     defines += [ "ENABLE_PLUGINS=1" ]
   }
   if (enable_pdf) {
     defines += [ "ENABLE_PDF=1" ]
   }
+  if (is_android) {
+    if (android_java_ui) {

[mfomitchev, 2015/11/19 15:41:05]

Why not just do && instead of nested ifs?

+      defines += [ "ANDROID_JAVA_UI=1" ]
+    }
+  }
   if (enable_basic_printing || enable_print_preview) {
     # Convenience define for ENABLE_BASIC_PRINTING || ENABLE_PRINT_PREVIEW.
     defines += [ "ENABLE_PRINTING=1" ]
     if (enable_basic_printing) {
       # Enable basic printing support and UI.
       defines += [ "ENABLE_BASIC_PRINTING=1" ]
     }
     if (enable_print_preview) {
       # Enable printing with print preview.
       # Can be defined without ENABLE_BASIC_PRINTING.
@@ skipping 353 matching lines @@
     # This error doesn't happen every time. In VS2013, it seems if the .pch
     # file doesn't exist, no error will be generated (probably MS tested this
     # case but forgot the other one?). To reproduce this error, do a build,
     # then delete the precompile.c.obj file, then build again.
     cflags_c = [ "/wd4206" ]
   } else if (is_mac && !is_official_build && !use_goma) {
     precompiled_header = "build/precompile.h"
     precompiled_source = "//build/precompile.h"
   }
 }