Issue 1459783006: [Contextual Search] Fix NPE when no Search Term.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1459783006: [Contextual Search] Fix NPE when no Search Term. (Closed)

Created:
5 years, 1 month ago by Donn Denman

Modified:
5 years, 1 month ago

Reviewers:
pedro (no code reviews)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Contextual Search] Fix NPE when no Search Term. BUG=558521 Committed: https://crrev.com/199a9933d119e1b3eb7e735ec249fa5cfeecbcb9 Cr-Commit-Position: refs/heads/master@{#360888}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459783006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459783006/1

5 years, 1 month ago (2015-11-20 18:42:12 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-20 19:50:03 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/199a9933d119e1b3eb7e735ec249fa5cfeecbcb9
Cr-Commit-Position: refs/heads/master@{#360888}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages