Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 1459783005: Do not use deprecated API in cctest/test-debug. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not use deprecated API in cctest/test-debug. R=jochen@chromium.org Committed: https://crrev.com/6980f1957d7d846ec11fd2bd1314a8f36ef4479c Cr-Commit-Position: refs/heads/master@{#32115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1522 lines, -1127 lines) Patch
M test/cctest/cctest.h View 2 chunks +19 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 251 chunks +1503 lines, -1127 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 1 month ago (2015-11-19 13:07:34 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-19 13:14:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459783005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459783005/1
5 years, 1 month ago (2015-11-19 13:26:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 13:45:48 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 13:46:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6980f1957d7d846ec11fd2bd1314a8f36ef4479c
Cr-Commit-Position: refs/heads/master@{#32115}

Powered by Google App Engine
This is Rietveld 408576698