Roll src/third_party/boringssl/src d7421ebf6..3ac32b1ed

Roll src/third_party/boringssl/src d7421ebf6..3ac32b1ed

https://boringssl.googlesource.com/boringssl/+log/d7421ebf6cae07051caf657016f160585b64f8a6..3ac32b1eda0da7a99d9c2b6c605fe50af80ccd90

In doing so, switch crypto/curve25519.h to use the new BoringSSL curve25510
code to avoid shipping two copies. This includes a small subgroup check, so
callers need to be tweaked slightly.

BUG=none

Committed: https://crrev.com/952ee79c0a17c2ed3ceeb4e22b7eafa0da41bbad
Cr-Commit-Position: refs/heads/master@{#360507}

[davidben, 2015-11-19 00:01:34]

Description was changed from

==========
Roll src/third_party/boringssl/src d7421ebf6..3ac32b1ed

https://boringssl.googlesource.com/boringssl/+log/d7421ebf6cae07051caf657016f...

In doing so, switch crypto/curve25519.h to use the new BoringSSL curve25510
code to avoid shipping two copies.

BUG=none
==========

to

==========
Roll src/third_party/boringssl/src d7421ebf6..3ac32b1ed

https://boringssl.googlesource.com/boringssl/+log/d7421ebf6cae07051caf657016f...

In doing so, switch crypto/curve25519.h to use the new BoringSSL curve25510
code to avoid shipping two copies. This includes a small subgroup check, so
callers need to be tweaked slightly.

BUG=none
==========

[davidben, 2015-11-19 00:16:18]

davidben@chromium.org changed reviewers:
+ agl@chromium.org, estark@chromium.org

[davidben, 2015-11-19 00:16:19]

estark for components/certificate_reporting/error_reporter.cc

https://codereview.chromium.org/1459783002/diff/20001/third_party/boringssl/b...
File third_party/boringssl/boringssl.gyp (right):

https://codereview.chromium.org/1459783002/diff/20001/third_party/boringssl/b...
third_party/boringssl/boringssl.gyp:105: 'OPENSSL_SMALL',
This is purely for the tests because ED25519 functions are missing, which I feel
kind of silly about. I like that most of our build toggles don't actually affect
the public API.

Thoughts? Another option is we teach generate_build_files.py that certain
outputs are OPENSSL_SMALL, or add a --small flag.

[estark, 2015-11-19 00:25:18]

components/certificate_reporting lgtm

https://codereview.chromium.org/1459783002/diff/20001/components/certificate_...
File components/certificate_reporting/error_reporter.cc (right):

https://codereview.chromium.org/1459783002/diff/20001/components/certificate_...
components/certificate_reporting/error_reporter.cc:80: return false;
nit: add a LOG(ERROR) here?

https://codereview.chromium.org/1459783002/diff/20001/components/certificate_...
components/certificate_reporting/error_reporter.cc:171: return false;
same nit here

[davidben, 2015-11-19 00:41:37]

https://codereview.chromium.org/1459783002/diff/20001/components/certificate_...
File components/certificate_reporting/error_reporter.cc (right):

https://codereview.chromium.org/1459783002/diff/20001/components/certificate_...
components/certificate_reporting/error_reporter.cc:80: return false;
On 2015/11/19 00:25:18, estark wrote:
> nit: add a LOG(ERROR) here?

Done.

https://codereview.chromium.org/1459783002/diff/20001/components/certificate_...
components/certificate_reporting/error_reporter.cc:171: return false;
On 2015/11/19 00:25:18, estark wrote:
> same nit here

Done.

[agl, 2015-11-19 00:47:12]

lgtm

[davidben, 2015-11-19 02:59:55]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-11-19 02:59:55]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/1459783002/#ps40001
(title: "fix build, estark comments")

[commit-bot: I haz the power, 2015-11-19 03:00:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459783002/40001

[commit-bot: I haz the power, 2015-11-19 03:06:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-19 03:07:34]

Patchset 3 (id:??) landed as
https://crrev.com/952ee79c0a17c2ed3ceeb4e22b7eafa0da41bbad
Cr-Commit-Position: refs/heads/master@{#360507}