Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1459763003: MIPS: Fixing failures in cctest/test-assembler-mips/CVT (Closed)

Created:
5 years, 1 month ago by ivica.bogosavljevic
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fixing failures in cctest/test-assembler-mips/CVT Fixing failures in cctest/test-assembler-mips/CVT on Mips32R2 without FP64 support BUG= Committed: https://crrev.com/ed600e5556bd3f668a427e7051ab66821c8558e1 Cr-Commit-Position: refs/heads/master@{#32121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M test/cctest/test-assembler-mips.cc View 12 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459763003/1
5 years, 1 month ago (2015-11-19 15:26:26 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 1 month ago (2015-11-19 15:26:27 UTC) #4
akos.palfi.imgtec
Lgtm, thanks!
5 years, 1 month ago (2015-11-19 15:54:01 UTC) #7
akos.palfi.imgtec
Nit: Please change the title to be 'MIPS: '.
5 years, 1 month ago (2015-11-19 15:55:31 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459763003/1
5 years, 1 month ago (2015-11-19 16:16:20 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 16:37:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459763003/1
5 years, 1 month ago (2015-11-19 16:37:58 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 16:39:16 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:40:07 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed600e5556bd3f668a427e7051ab66821c8558e1
Cr-Commit-Position: refs/heads/master@{#32121}

Powered by Google App Engine
This is Rietveld 408576698