|
|
DescriptionFix typo in GN get_label_info help
BUG=None
Committed: https://crrev.com/de3c7279759c9bf318961371c5454eeecac508a3
Cr-Commit-Position: refs/heads/master@{#360924}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 18 (7 generated)
pkotwicz@chromium.org changed reviewers: + agrieve@chromium.org
agrieve@ PTAL
tfarina@chromium.org changed reviewers: + tfarina@chromium.org
https://codereview.chromium.org/1459733004/diff/1/tools/gn/function_get_label... File tools/gn/function_get_label_info.cc (right): https://codereview.chromium.org/1459733004/diff/1/tools/gn/function_get_label... tools/gn/function_get_label_info.cc:66: " match the value of the \"root_out_dir\" variable when inside that\n" lgtm
On 2015/11/19 16:31:33, tfarina wrote: > https://codereview.chromium.org/1459733004/diff/1/tools/gn/function_get_label... > File tools/gn/function_get_label_info.cc (right): > > https://codereview.chromium.org/1459733004/diff/1/tools/gn/function_get_label... > tools/gn/function_get_label_info.cc:66: " match the value of the > \"root_out_dir\" variable when inside that\n" > lgtm lgtm
brettw@ for OWNERS
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459733004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Fix typo in GN get_label_info help BUG=None ========== to ========== Fix typo in GN get_label_info help BUG=None ==========
pkotwicz@chromium.org changed reviewers: + brettw@chromium.org
brettw@ for OWNERS
lgtm
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459733004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/de3c7279759c9bf318961371c5454eeecac508a3 Cr-Commit-Position: refs/heads/master@{#360924} |