Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1459733004: Fix typo in GN get_label_info help (Closed)

Created:
5 years, 1 month ago by pkotwicz
Modified:
5 years, 1 month ago
Reviewers:
tfarina, brettw, agrieve
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in GN get_label_info help BUG=None Committed: https://crrev.com/de3c7279759c9bf318961371c5454eeecac508a3 Cr-Commit-Position: refs/heads/master@{#360924}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/function_get_label_info.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 18 (7 generated)
pkotwicz
agrieve@ PTAL
5 years, 1 month ago (2015-11-19 16:16:41 UTC) #2
tfarina
https://codereview.chromium.org/1459733004/diff/1/tools/gn/function_get_label_info.cc File tools/gn/function_get_label_info.cc (right): https://codereview.chromium.org/1459733004/diff/1/tools/gn/function_get_label_info.cc#newcode66 tools/gn/function_get_label_info.cc:66: " match the value of the \"root_out_dir\" variable when ...
5 years, 1 month ago (2015-11-19 16:31:33 UTC) #4
agrieve
On 2015/11/19 16:31:33, tfarina wrote: > https://codereview.chromium.org/1459733004/diff/1/tools/gn/function_get_label_info.cc > File tools/gn/function_get_label_info.cc (right): > > https://codereview.chromium.org/1459733004/diff/1/tools/gn/function_get_label_info.cc#newcode66 > ...
5 years, 1 month ago (2015-11-19 20:02:39 UTC) #5
pkotwicz
brettw@ for OWNERS
5 years, 1 month ago (2015-11-19 20:22:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459733004/1
5 years, 1 month ago (2015-11-20 01:29:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/120522)
5 years, 1 month ago (2015-11-20 01:42:47 UTC) #10
pkotwicz
brettw@ for OWNERS
5 years, 1 month ago (2015-11-20 04:46:57 UTC) #13
brettw
lgtm
5 years, 1 month ago (2015-11-20 21:41:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459733004/1
5 years, 1 month ago (2015-11-20 21:55:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 22:04:55 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 23:03:21 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de3c7279759c9bf318961371c5454eeecac508a3
Cr-Commit-Position: refs/heads/master@{#360924}

Powered by Google App Engine
This is Rietveld 408576698