Source/modules/encoding/TextDecoder.cpp - Issue 145973021: Implement "replacement" text encoding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/encoding/TextDecoder.cpp

Issue 145973021: Implement "replacement" text encoding. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reworked tests, still WIP Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/encoding/TextDecoder.cpp

diff --git a/Source/modules/encoding/TextDecoder.cpp b/Source/modules/encoding/TextDecoder.cpp

index 84df22cad1c6f5b8fa545d123d5e612747d6da51..86ada4928f85aa58970acd69811fa4bdecd87b00 100644

--- a/Source/modules/encoding/TextDecoder.cpp

+++ b/Source/modules/encoding/TextDecoder.cpp

@@ -43,7 +43,7 @@ TextDecoder* TextDecoder::create(const String& label, const Dictionary& options,

const String& encodingLabel = label.isNull() ? String("utf-8") : label;

WTF::TextEncoding encoding(encodingLabel);

- if (!encoding.isValid()) {

+ if (!encoding.isValid() || !strcmp(encoding.name(), "replacement")) {

exceptionState.throwTypeError("The encoding label provided ('" + encodingLabel + "') is invalid.");

return 0;

}