Exclude IDS_CERT strings that are not used on Android.

Exclude IDS_CERT strings that are not used on Android.

BUG=326023
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249089

[aurimas (slooooooooow), 2014-02-04 17:58:55]

Hey Newton,

Please take a look at this change.

Thanks,
Aurimas

[newt (away), 2014-02-04 19:42:13]

https://codereview.chromium.org/145973020/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/145973020/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:2616: +      <if
expr="pp_ifdef('desktop_linux')">
I'd set the toolkit_uses_gtk grit variable in common.gypi and use that here
instead of desktop_linux

https://codereview.chromium.org/145973020/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:2655: +      <!-- Certificate viewer dialog
strings.  These are used in WebUI and GTK certificate viewers. -->
maybe mention here that on Android we use an OS-level certificate manager

https://codereview.chromium.org/145973020/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:3282: +        <if
expr="pp_ifdef('chromeos')">
I'd move this outside of the "if not is_android" section

[aurimas (slooooooooow), 2014-02-05 00:23:32]

https://codereview.chromium.org/145973020/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/145973020/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:2616: +      <if
expr="pp_ifdef('desktop_linux')">
On 2014/02/04 19:42:14, newt wrote:
> I'd set the toolkit_uses_gtk grit variable in common.gypi and use that here
> instead of desktop_linux

Done.

https://codereview.chromium.org/145973020/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:2655: +      <!-- Certificate viewer dialog
strings.  These are used in WebUI and GTK certificate viewers. -->
On 2014/02/04 19:42:14, newt wrote:
> maybe mention here that on Android we use an OS-level certificate manager

Done.

https://codereview.chromium.org/145973020/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:3282: +        <if
expr="pp_ifdef('chromeos')">
On 2014/02/04 19:42:14, newt wrote:
> I'd move this outside of the "if not is_android" section

Done.

[newt (away), 2014-02-05 00:52:04]

lgtm

[aurimas (slooooooooow), 2014-02-05 17:05:59]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-02-05 17:11:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/145973020/70001

[commit-bot: I haz the power, 2014-02-05 19:56:31]

Change committed as 249089