Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145973017: Fix opening images from the downloads shelf. (Closed)

Created:
6 years, 10 months ago by mtomasz
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix opening images from the downloads shelf. Because of a typo during refactoring, the url wasn't passed correctly. This patch fixes the typo. TEST=Tested manually with an image on the downloads shelf. BUG=340176 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
mtomasz
@hirono: PTAL. Thanks!
6 years, 10 months ago (2014-02-04 00:53:27 UTC) #1
hirono
lgtm!
6 years, 10 months ago (2014-02-04 02:27:05 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 10 months ago (2014-02-04 02:27:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/145973017/1
6 years, 10 months ago (2014-02-04 02:27:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 03:34:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=145861
6 years, 10 months ago (2014-02-04 03:34:10 UTC) #6
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 10 months ago (2014-02-04 08:32:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/145973017/1
6 years, 10 months ago (2014-02-04 08:33:16 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 10:34:47 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223004
6 years, 10 months ago (2014-02-04 10:34:48 UTC) #10
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 10 months ago (2014-02-05 02:55:24 UTC) #11
mtomasz
The CQ bit was unchecked by mtomasz@chromium.org
6 years, 10 months ago (2014-02-05 03:38:07 UTC) #12
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 10 months ago (2014-02-05 03:38:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/145973017/1
6 years, 10 months ago (2014-02-05 03:42:22 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:55:20 UTC) #15
Message was sent while issue was closed. 
Change committed as 248886

Powered by Google App Engine
This is Rietveld 408576698