Issue 145973006: Do not overwrite builtin code names in heap profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145973006: Do not overwrite builtin code names in heap profiler (Closed)

Created:
6 years, 10 months ago by alph

Modified:
6 years, 10 months ago

Reviewers:
ulan, yurys, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Do not overwrite builtin code names in heap profiler Make sure builtin code objects get their builtin tags first. Otherwise a particular JSFunction object could set its custom name to a generic builtin. LOG=N R=ulan@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18926

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -27 lines)			Patch
M	src/heap-snapshot-generator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap-snapshot-generator.cc	View	4 chunks	+23 lines, -23 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+13 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

alph

6 years, 10 months ago (2014-01-29 17:03:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r18926 (presubmit successful).