third_party/protobuf/protobuf.gyp - Issue 14597007: Support target/host architecture with ninja iOS builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/protobuf.gyp

Issue 14597007: Support target/host architecture with ninja iOS builds (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/protobuf.gyp

diff --git a/third_party/protobuf/protobuf.gyp b/third_party/protobuf/protobuf.gyp

index 772bc1060e329ba4014f2aa7e26574b3f9d08f10..73c23ccae81bfe3180873fad7b413099f9606956 100644

--- a/third_party/protobuf/protobuf.gyp

+++ b/third_party/protobuf/protobuf.gyp

@@ -28,7 +28,7 @@

}],

- ['OS=="ios"', {

+ ['OS=="ios" and "<(GENERATOR)"!="ninja"', {

'variables': {

'ninja_output_dir': 'ninja-protoc',

'ninja_product_dir':

@@ -205,7 +205,7 @@

{

'target_name': 'protoc',

'conditions': [

- ['OS!="ios"', {

+ ['OS!="ios" or "<(GENERATOR)"=="ninja"', {

'type': 'executable',

'toolsets': ['host'],

'sources': [