Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1459633004: Pull CSS-wide keyword handling out of LegacyCSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ruletype
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index e6164d826721bbfc7c34de692bdbb509b535fd62..1d70429b428ab35546e5c7a64db6304bd2dcca67 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -354,23 +354,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
CSSValueID id = value->id;
- if (id == CSSValueInherit) {
- if (m_valueList->size() != 1)
- return false;
- addExpandedPropertyForValue(propId, cssValuePool().createInheritedValue(), important);
- return true;
- } else if (id == CSSValueInitial) {
- if (m_valueList->size() != 1)
- return false;
- addExpandedPropertyForValue(propId, cssValuePool().createExplicitInitialValue(), important);
- return true;
- } else if (id == CSSValueUnset) {
- if (m_valueList->size() != 1)
- return false;
- addExpandedPropertyForValue(propId, cssValuePool().createUnsetValue(), important);
- return true;
- }
-
+ // TODO(timloh): Move to parseValueStart
if (RuntimeEnabledFeatures::cssVariablesEnabled() && value->id == CSSValueInternalVariableValue) {
// We don't expand the shorthand here because crazypants.
m_parsedProperties.append(CSSProperty(propId, CSSVariableReferenceValue::create(value->variableData), important, false, 0, m_implicitShorthand));
@@ -378,6 +362,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
return true;
}
+ // TODO(timloh): Move to parseSingleValue
if (CSSParserFastPaths::isKeywordPropertyID(propId)) {
if (!CSSParserFastPaths::isValidKeywordPropertyAndValue(propId, id))
return false;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698