net/socket/socks_client_socket_pool_unittest.cc - Issue 1459633003: Remove ScopedVector from net/socket tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket_pool_unittest.cc

Issue 1459633003: Remove ScopedVector from net/socket tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/socks_client_socket_pool_unittest.cc

diff --git a/net/socket/socks_client_socket_pool_unittest.cc b/net/socket/socks_client_socket_pool_unittest.cc

index e841c83635d7fc3813e1b08a7f01c5156481bbc2..587f1fa5fa5a1d87a76067716343053141f9b1b5 100644

--- a/net/socket/socks_client_socket_pool_unittest.cc

+++ b/net/socket/socks_client_socket_pool_unittest.cc

@@ -109,7 +109,9 @@ class SOCKSClientSocketPoolTest : public testing::Test {

return test_base_.GetOrderOfRequest(index);

}

- ScopedVector<TestSocketRequest>* requests() { return test_base_.requests(); }

+ std::vector<scoped_ptr<TestSocketRequest>>* requests() {

+ return test_base_.requests();

+ }

MockClientSocketFactory transport_client_socket_factory_;

MockTransportClientSocketPool transport_socket_pool_;