third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 1459603002: Implement the 'noopener' window feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 1459603002: Implement the 'noopener' window feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ugh. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index 2efdc8567c68547b6998a86cdac47713c39a9357..652db6308f69ee7c7ef47fa086dec0d505cdf9c0 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -1496,7 +1496,9 @@ PassRefPtrWillBeRawPtr<DOMWindow> LocalDOMWindow::open(const String& urlString,

return targetFrame->domWindow();

}

- return createWindow(urlString, frameName, WindowFeatures(windowFeaturesString), *callingWindow, *firstFrame, *frame());

+ WindowFeatures features(windowFeaturesString);

+ RefPtrWillBeRawPtr<DOMWindow> newWindow = createWindow(urlString, frameName, features, *callingWindow, *firstFrame, *frame());

+ return features.noopener ? nullptr : newWindow;

}

DEFINE_TRACE(LocalDOMWindow)