third_party/WebKit/Source/core/frame/Window.idl - Issue 1459603002: Implement the 'noopener' window feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 1459603002: Implement the 'noopener' window feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nasko Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Window.idl

diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl

index 23fef6a193f06804ed2dae44f09eeaeb628df3d1..81c4f31e3c1da6c79d37073098abb7dc59a6df51 100644

--- a/third_party/WebKit/Source/core/frame/Window.idl

+++ b/third_party/WebKit/Source/core/frame/Window.idl

@@ -62,7 +62,7 @@

[Replaceable, DoNotCheckSecurity] readonly attribute Window parent;

[CheckSecurity=Node, Custom=Getter] readonly attribute Element? frameElement;

// FIXME: open() should have 4 optional arguments with defaults.

- [Custom] Window open(DOMString url, DOMString target, optional DOMString features);

+ [Custom] Window? open(DOMString url, DOMString target, optional DOMString features);

// FIXME: These getters should not have [NotEnumerable].

[NotEnumerable, DoNotCheckSecurity] getter Window (unsigned long index);

[Custom, NotEnumerable, DoNotCheckSecurity] getter object (DOMString name);