Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5225)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1459593002: Added a UI for the Interests Prototype. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 2122168a29a5658c8104903d9f28c47e428f828b..6fe73a2bfb8703c6b438df5b675613bd147c4f17 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -36,6 +36,7 @@ import org.chromium.chrome.browser.favicon.LargeIconBridge;
import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
import org.chromium.chrome.browser.metrics.StartupMetrics;
import org.chromium.chrome.browser.ntp.BookmarksPage.BookmarkSelectedListener;
+import org.chromium.chrome.browser.ntp.InterestsPage.InterestsClickListener;
import org.chromium.chrome.browser.ntp.LogoBridge.Logo;
import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
@@ -169,6 +170,26 @@ public class NewTabPage
}
}
+ public static void launchInterestsDialog(Activity activity, final Tab tab) {
+ InterestsPage page =
+ new InterestsPage(activity, tab, Profile.getLastUsedProfile(), activity);
+ final Dialog dialog = new NativePageDialog(activity, page);
+
+ InterestsClickListener listener = new InterestsClickListener() {
+ @Override
+ public void onInterestClicked(String name) {
+ tab.loadUrl(new LoadUrlParams(
+ TemplateUrlService.getInstance().getUrlForSearchQuery(name)));
+
+ dialog.dismiss();
newt (away) 2015/12/12 00:30:31 style nit: there's a few too many newlines here IM
PEConn 2015/12/14 17:05:16 Done.
+ }
+ };
+
+ page.setListener(listener);
+
+ dialog.show();
+ }
+
public static void launchRecentTabsDialog(Activity activity, Tab tab) {
DocumentRecentTabsManager manager = new DocumentRecentTabsManager(tab, activity);
NativePage page = new RecentTabsPage(activity, manager);
@@ -315,6 +336,13 @@ public class NewTabPage
}
@Override
+ public void navigateToInterests() {
+ if (mIsDestroyed) return;
+ RecordUserAction.record("MobileNTP.Interests.OpenDialog");
+ launchInterestsDialog(mActivity, mTab);
newt (away) 2015/12/12 00:30:31 what happens on tablets? A fullscreen dialog?
PEConn 2015/12/14 17:05:15 Yes, for the moment. As you suggested in Interests
+ }
+
+ @Override
public void focusSearchBox(boolean beginVoiceSearch, String pastedText) {
if (mIsDestroyed) return;
if (mFakeboxDelegate != null) {
@@ -659,4 +687,5 @@ public class NewTabPage
mDialog = dialog;
}
}
+
newt (away) 2015/12/12 00:30:31 remove this
PEConn 2015/12/14 17:05:16 Done.
}

Powered by Google App Engine
This is Rietveld 408576698