chrome/android/java/res/layout/interests_page.xml - Issue 1459593002: Added a UI for the Interests Prototype.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/interests_page.xml

Issue 1459593002: Added a UI for the Interests Prototype. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <org.chromium.chrome.browser.ntp.InterestsView

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:layout_width="match_parent"

	9 android:layout_height="match_parent"

	10 android:paddingTop="@dimen/tab_strip_height"

	11 android:orientation="vertical"

	12 android:focusable="true"
	Bernhard Bauer 2015/11/19 17:15:15 Sort these alphabetically? Sort these alphabetically? PEConn 2015/11/20 11:23:40 I did this for all elements except verticalSpacing Show quoted text On 2015/11/19 17:15:15, Bernhard Bauer wrote: > Sort these alphabetically? I did this for all elements except verticalSpacing (which I put directly after horizontalSpacing). It's ugly, but I think they're related so should be next to each other.
	13 android:focusableInTouchMode="true" >

	14

	15 <GridView

	16 android:id="@+id/interests_list_view"

	17 android:layout_width="match_parent"

	18 android:layout_height="match_parent"

	19 android:paddingTop="@dimen/toolbar_height_no_shadow"

	20 android:numColumns="auto_fit"

	21 android:verticalSpacing="10dp"

	22 android:horizontalSpacing="10dp"

	23 android:stretchMode="columnWidth"

	24 android:gravity="center" />

	25

	26 </org.chromium.chrome.browser.ntp.InterestsView>

OLD	NEW