Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1459583002: Fixing a hard dependency on dom_distiller_core. (Closed)

Created:
5 years, 1 month ago by noyau (Ping after 24h)
Modified:
5 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing a hard dependency on dom_distiller_core. BUG=546142 Committed: https://crrev.com/8edc0eb233ddea494ea3e30a79b07ec7e4fdb604 Cr-Commit-Position: refs/heads/master@{#360329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/ios_chrome.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
noyau (Ping after 24h)
Chased this issue with blundell@, I now know all about hard dependencies in gyp. Yay!
5 years, 1 month ago (2015-11-18 13:00:19 UTC) #2
sdefresne
lgtm
5 years, 1 month ago (2015-11-18 13:57:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459583002/1
5 years, 1 month ago (2015-11-18 14:00:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/110250)
5 years, 1 month ago (2015-11-18 14:02:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459583002/1
5 years, 1 month ago (2015-11-18 14:39:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 14:48:57 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 14:50:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8edc0eb233ddea494ea3e30a79b07ec7e4fdb604
Cr-Commit-Position: refs/heads/master@{#360329}

Powered by Google App Engine
This is Rietveld 408576698