Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1459543003: [Interpreter] Add support for unary operators to bytecode graph builder. (Closed)

Created:
5 years, 1 month ago by mythria
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for unary operators to bytecode graph builder. Adds implementation and tests for LogicalNot, TypeOf and Delete operators to bytecode graph builder. BUG=v8:4280 LOG=N Committed: https://crrev.com/a8e86c49ec7e86eaa23ede6531a7d1c55b9478db Cr-Commit-Position: refs/heads/master@{#32104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -4 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +22 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 3 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mythria
Could you please review my changes. Thanks, Mythri
5 years, 1 month ago (2015-11-18 10:43:10 UTC) #2
oth
Nice tests. lgtm.
5 years, 1 month ago (2015-11-18 14:43:35 UTC) #3
Benedikt Meurer
LGTM on compiler.
5 years, 1 month ago (2015-11-19 04:54:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459543003/1
5 years, 1 month ago (2015-11-19 09:37:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 09:38:38 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 09:39:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8e86c49ec7e86eaa23ede6531a7d1c55b9478db
Cr-Commit-Position: refs/heads/master@{#32104}

Powered by Google App Engine
This is Rietveld 408576698